From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Feature freeze Date: Mon, 06 Jan 2014 19:19:47 -0500 Message-ID: References: <87d2kmuyxg.fsf@engster.org> <87eh4kzss5.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389054002 12929 80.91.229.3 (7 Jan 2014 00:20:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jan 2014 00:20:02 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 07 01:20:06 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0KOs-0004W6-3R for ged-emacs-devel@m.gmane.org; Tue, 07 Jan 2014 01:20:06 +0100 Original-Received: from localhost ([::1]:38206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KOr-0000hb-Ko for ged-emacs-devel@m.gmane.org; Mon, 06 Jan 2014 19:20:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KOh-0000gE-P3 for emacs-devel@gnu.org; Mon, 06 Jan 2014 19:20:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0KOa-0006Bc-Et for emacs-devel@gnu.org; Mon, 06 Jan 2014 19:19:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:62489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KOa-0006BX-Ag for emacs-devel@gnu.org; Mon, 06 Jan 2014 19:19:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxKG9/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFFxKG9/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44299350" Original-Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jan 2014 19:19:47 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B22B062F04; Mon, 6 Jan 2014 19:19:47 -0500 (EST) In-Reply-To: <87eh4kzss5.fsf@engster.org> (David Engster's message of "Mon, 06 Jan 2014 22:47:54 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167553 Archived-At: > Is it OK to install, or will it have to wait? Looks OK. Please install, tho see nitpicks below. > + ;; Describe all the slots in this class Please punctuate the comments (IIUC you didn't actually change this comment, but while you're there, you might as well do it ;-). > +(defvar help-fns-describe-function-functions nil > + "List of functions to run in help buffer in `describe-function'. > +Those functions will be run after the header line and argument > +list was inserted, and before the documentation will be inserted. > +The functions will receive the function name as argument.") > + > ;; Functions > > ;;;###autoload > @@ -653,7 +659,7 @@ > (help-fns--compiler-macro function) > (help-fns--parent-mode function) > (help-fns--obsolete function) > - > + (run-hook-with-args 'help-fns-describe-function-functions function) Looks good, but please move help-fns--compiler-macro, help-fns--parent-mode, help-fns--obsolete to help-fns-describe-function-functions while you're there. Stefan