From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs 24.4 and advice Date: Fri, 31 Oct 2014 13:47:55 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414785010 18820 80.91.229.3 (31 Oct 2014 19:50:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2014 19:50:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Trey Jackson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 31 20:50:02 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XkICv-0002Gi-R6 for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2014 20:50:01 +0100 Original-Received: from localhost ([::1]:42110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkICv-0000me-Cx for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2014 15:50:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkGIu-0003Ln-4o for emacs-devel@gnu.org; Fri, 31 Oct 2014 13:48:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XkGIm-0007Y2-Lg for emacs-devel@gnu.org; Fri, 31 Oct 2014 13:48:04 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:34562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkGIm-0007Xp-Hu for emacs-devel@gnu.org; Fri, 31 Oct 2014 13:47:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au4MAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBAwFWIwULCw4mEhQYDSQtiB4Jy3IBAQEHAiCRCAeESwWZEoYAjV6FMIFvhBQhgnoBAQE X-IPAS-Result: Au4MAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBAwFWIwULCw4mEhQYDSQtiB4Jy3IBAQEHAiCRCAeESwWZEoYAjV6FMIFvhBQhgnoBAQE X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="95684376" Original-Received: from 69-165-143-59.dsl.teksavvy.com (HELO pastel.home) ([69.165.143.59]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 31 Oct 2014 13:47:55 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6D20062BA; Fri, 31 Oct 2014 13:47:55 -0400 (EDT) In-Reply-To: (Trey Jackson's message of "Thu, 30 Oct 2014 09:26:17 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176146 Archived-At: > I looked at the NEWS - no mention of the function being deprecated. Indeed, I never heard or seen anyone or any package refer to those two functions (ad-start-advice and ad-stop-advice), so I didn't think it was worth mentioning in NEWS (every release comes with loads of such "too internal to merit mention" changes). It looked like left over code from a very long time ago. What do you use them for? > I'm not reporting this as a bug, because I can just update my code to work > around this, but I do think that the changes made to this package could > have been handled more gracefully. The addition of nadvice required many changes in advice.el's internals (these were indispensable in order for the two packages not to step on each other's toes), so indeed there have been various compatibility issues, and I've done my best to address them. > Whatever you think of people (over)using 'advice, the 'ad-start-advice and > 'ad-stop-advice were a part of the tutorial and documentation in 24.3. Which tutorial are you referring to? Stefan