From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Trey Jackson <bigfaceworm@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs 24.4 and advice
Date: Fri, 31 Oct 2014 13:47:55 -0400 [thread overview]
Message-ID: <jwvh9ykyw8o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CABainDxcBcgD57_zLf1m1MFzkmucBeaCwoa78YVOsjgZSb0xYA@mail.gmail.com> (Trey Jackson's message of "Thu, 30 Oct 2014 09:26:17 -0700")
> I looked at the NEWS - no mention of the function being deprecated.
Indeed, I never heard or seen anyone or any package refer to those two
functions (ad-start-advice and ad-stop-advice), so I didn't think it was
worth mentioning in NEWS (every release comes with loads of such "too
internal to merit mention" changes). It looked like left over code from
a very long time ago.
What do you use them for?
> I'm not reporting this as a bug, because I can just update my code to work
> around this, but I do think that the changes made to this package could
> have been handled more gracefully.
The addition of nadvice required many changes in advice.el's internals
(these were indispensable in order for the two packages not to step on
each other's toes), so indeed there have been various compatibility
issues, and I've done my best to address them.
> Whatever you think of people (over)using 'advice, the 'ad-start-advice and
> 'ad-stop-advice were a part of the tutorial and documentation in 24.3.
Which tutorial are you referring to?
Stefan
next prev parent reply other threads:[~2014-10-31 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 16:26 Emacs 24.4 and advice Trey Jackson
2014-10-31 17:47 ` Stefan Monnier [this message]
2014-10-31 18:02 ` Trey Jackson
2014-10-31 19:02 ` Stefan Monnier
2014-10-31 19:26 ` Trey Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9ykyw8o.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bigfaceworm@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.