From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19250: elisp-mode.el: completion-at-point fails at M-: for some buffers Date: Wed, 03 Dec 2014 13:23:42 -0500 Message-ID: References: <87fvcyqt25.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417631071 32659 80.91.229.3 (3 Dec 2014 18:24:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 18:24:31 +0000 (UTC) Cc: 19250@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 03 19:24:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwEb7-0007l6-Aq for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2014 19:24:21 +0100 Original-Received: from localhost ([::1]:42842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwEb6-0002d2-FN for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2014 13:24:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwEaw-0002cv-MS for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2014 13:24:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwEap-0000ZT-2R for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2014 13:24:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwEao-0000ZN-VM for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2014 13:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XwEao-0003MX-CV for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2014 13:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Dec 2014 18:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19250-submit@debbugs.gnu.org id=B19250.141763103212905 (code B ref 19250); Wed, 03 Dec 2014 18:24:02 +0000 Original-Received: (at 19250) by debbugs.gnu.org; 3 Dec 2014 18:23:52 +0000 Original-Received: from localhost ([127.0.0.1]:52923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwEad-0003M5-Qe for submit@debbugs.gnu.org; Wed, 03 Dec 2014 13:23:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:59223) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwEac-0003Lx-9S for 19250@debbugs.gnu.org; Wed, 03 Dec 2014 13:23:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjsPAOwQflRMCqTq/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCws0EhQYDSSISgnWWQEBAQEGAQEBAR6QbweESAWLAZIxhlGLLIF4hBkhgncBAQE X-IPAS-Result: AjsPAOwQflRMCqTq/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCws0EhQYDSSISgnWWQEBAQEGAQEBAR6QbweESAWLAZIxhlGLLIF4hBkhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="99481004" Original-Received: from 76-10-164-234.dsl.teksavvy.com (HELO pastel.home) ([76.10.164.234]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Dec 2014 13:23:48 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8B5EF88E1; Wed, 3 Dec 2014 13:23:42 -0500 (EST) In-Reply-To: <87fvcyqt25.fsf@violet.siamics.net> (Ivan Shmakov's message of "Tue, 02 Dec 2014 09:50:26 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96824 Archived-At: > This seems to happen because elisp--local-variables tries to > gather variable names for completion from the contents of the > buffer M-: is invoked from, while such buffer does not > necessarily hold any (valid) Emacs Lisp code. Indeed we have two bugs: we gather the local vars from the wrong buffer, and we don't ignore invalid-read-syntax errors (which can happen in various other legitimate cases). The second bug is trivial to fix, the first is a bit more delicate because the buffer-switching is done by completion-table-dynamic and I'm pretty sure it's done for a good reason (i.e. while it's undesirable here, it's desirable in some other case(s)), so we'll first have to figure out which are those other cases and how to fix this case without breaking those others. Stefan