From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 19250@debbugs.gnu.org
Subject: bug#19250: elisp-mode.el: completion-at-point fails at M-: for some buffers
Date: Wed, 03 Dec 2014 13:23:42 -0500 [thread overview]
Message-ID: <jwvh9xch9y4.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87fvcyqt25.fsf@violet.siamics.net> (Ivan Shmakov's message of "Tue, 02 Dec 2014 09:50:26 +0000")
> This seems to happen because elisp--local-variables tries to
> gather variable names for completion from the contents of the
> buffer M-: is invoked from, while such buffer does not
> necessarily hold any (valid) Emacs Lisp code.
Indeed we have two bugs: we gather the local vars from the wrong buffer,
and we don't ignore invalid-read-syntax errors (which can happen in
various other legitimate cases).
The second bug is trivial to fix, the first is a bit more delicate
because the buffer-switching is done by completion-table-dynamic and I'm
pretty sure it's done for a good reason (i.e. while it's undesirable
here, it's desirable in some other case(s)), so we'll first have to
figure out which are those other cases and how to fix this case
without breaking those others.
Stefan
next prev parent reply other threads:[~2014-12-03 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 9:50 bug#19250: elisp-mode.el: completion-at-point fails at M-: for some buffers Ivan Shmakov
2014-12-03 18:23 ` Stefan Monnier [this message]
2014-12-03 19:39 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9xch9y4.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=19250@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.