From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names. Date: Fri, 16 Jan 2015 11:38:26 -0500 Message-ID: References: <20150111150204.28178.44482@vcs.savannah.gnu.org> <878uh8e3gf.fsf@gmx.de> <8761cc80ja.fsf@gmx.de> <878uh2210p.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421426324 28603 80.91.229.3 (16 Jan 2015 16:38:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Jan 2015 16:38:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 16 17:38:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YC9v1-00033O-8W for ged-emacs-devel@m.gmane.org; Fri, 16 Jan 2015 17:38:43 +0100 Original-Received: from localhost ([::1]:56420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC9v0-00009r-Le for ged-emacs-devel@m.gmane.org; Fri, 16 Jan 2015 11:38:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC9uw-00009V-Fc for emacs-devel@gnu.org; Fri, 16 Jan 2015 11:38:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC9ut-0005C2-9w for emacs-devel@gnu.org; Fri, 16 Jan 2015 11:38:38 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC9ut-0005Bu-5h for emacs-devel@gnu.org; Fri, 16 Jan 2015 11:38:35 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0GGcRwG023877; Fri, 16 Jan 2015 11:38:27 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 0D91625F2; Fri, 16 Jan 2015 11:38:27 -0500 (EST) In-Reply-To: <878uh2210p.fsf@gmx.de> (Michael Albinus's message of "Fri, 16 Jan 2015 16:33:42 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5188=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5188> : inlines <1791> : streams <1374403> : uri <1842626> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181334 Archived-At: >> Is it a real problem? I mean, in which circumstance did you end up >> doing (directory-files-recursively "/" "")? > I wanted to explore the new directory-files-recursively, and it was the > first test which came to my mind. The shortest one to type. So you didn't like the behavior, but it's not like that behavior was non-sensical. > It is a corner case only, of course. Do you believe my patch hurts? It's > just one line, w/o performance penalties. The problem with the patch is that you now have an ad-hoc workaround for Tramp inside an otherwise perfectly generic function. If it's really needed, we can live with it and it's not the end of the world, but it seems that the need for it is not very strong, so I'm leaning towards removing it. Stefan