From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Making edebug work with Follow Mode Date: Sun, 15 Mar 2015 15:12:16 -0400 Message-ID: References: <20150315135527.GA3800@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426446768 8190 80.91.229.3 (15 Mar 2015 19:12:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Mar 2015 19:12:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 15 20:12:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXDxl-0008Eq-3B for ged-emacs-devel@m.gmane.org; Sun, 15 Mar 2015 20:12:37 +0100 Original-Received: from localhost ([::1]:44468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXDxk-00046J-Bf for ged-emacs-devel@m.gmane.org; Sun, 15 Mar 2015 15:12:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXDxW-000462-P5 for emacs-devel@gnu.org; Sun, 15 Mar 2015 15:12:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXDxS-0007Sk-FR for emacs-devel@gnu.org; Sun, 15 Mar 2015 15:12:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:48495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXDxS-0007SM-C3 for emacs-devel@gnu.org; Sun, 15 Mar 2015 15:12:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArsTAPOG1lQXW5EB/2dsb2JhbABbgwaDX4VTwGUEAgKBDUQBAQEBAQF8hA0BBAFWIwULCw4mEhQYDSSIOAjOIwEBAQcCAR+PeAeEKgWrNyKECiKCcwEBAQ X-IPAS-Result: ArsTAPOG1lQXW5EB/2dsb2JhbABbgwaDX4VTwGUEAgKBDUQBAQEBAQF8hA0BBAFWIwULCw4mEhQYDSSIOAjOIwEBAQcCAR+PeAeEKgWrNyKECiKCcwEBAQ X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="113622821" Original-Received: from 23-91-145-1.cpe.pppoe.ca (HELO ceviche.home) ([23.91.145.1]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Mar 2015 15:12:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 57A1766108; Sun, 15 Mar 2015 15:12:16 -0400 (EDT) In-Reply-To: <20150315135527.GA3800@acm.fritz.box> (Alan Mackenzie's message of "Sun, 15 Mar 2015 13:55:27 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183885 Archived-At: > There are two reasons for this failure. The main one is that edebug > binds post-command-hook to nil, switching off Follow Mode's mechanism. FWIW, in my local edebug.el I removed these let-bindings of pre/post-command-hook a long time ago and never looked back. So I'm in favor of simply removing them altogether. > As the subsidiary fix, I've commented out edebug-adjust-windows and the > call to it. Sounds OK. If/when someone complains about a particular side-effect, we can see how to get it back in a less heavy-handed way than edebug-adjust-windows. Stefan