all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* magit, changelogs and commit formatting
@ 2015-09-11 15:38 Eric Abrahamsen
  2015-09-11 15:50 ` Dmitry Gutov
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Abrahamsen @ 2015-09-11 15:38 UTC (permalink / raw)
  To: help-gnu-emacs

I know we're supposed to move to automatically-generated changelogs Real
Soon Now, but in the meantime...

I'm having a bit of confusion about the best way to format git patches
for Emacs packages. I've pushed a few almost-but-not-quite patches that
other people have had to fix afterwards (I'm talking about commit
message formatting), and that's embarrassing. What I've done in the past
is start the commit from Magit, then hit "C" in the patch buffer, which
inserts a fairly intelligent log template into the commit message
buffer, and then I work with that.

But of course the ChangeLog is supposed to be part of the commit, which
means these messages have to be created before I even get to the commit
buffer, which so far has meant a lot of manually adding function names
and parentheses and making sure there are two spaces between the date
and my name/address.

Is there a different magic function I'm missing? Can some greybeard
quickly share a workflow? How does everyone else do this?

Any hints appreciated,

Eric




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: magit, changelogs and commit formatting
  2015-09-11 15:38 magit, changelogs and commit formatting Eric Abrahamsen
@ 2015-09-11 15:50 ` Dmitry Gutov
  2015-09-11 16:20   ` Eric Abrahamsen
  2015-09-11 16:59   ` Stefan Monnier
  0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Gutov @ 2015-09-11 15:50 UTC (permalink / raw)
  To: Eric Abrahamsen, help-gnu-emacs

Hi Eric,

On 09/11/2015 06:38 PM, Eric Abrahamsen wrote:
> I know we're supposed to move to automatically-generated changelogs Real
> Soon Now, but in the meantime...

We've transitioned to it already.

> I'm having a bit of confusion about the best way to format git patches
> for Emacs packages.

Not sure about third-party packages, but for patches for Emacs, see 
CONTRIBUTE.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: magit, changelogs and commit formatting
  2015-09-11 15:50 ` Dmitry Gutov
@ 2015-09-11 16:20   ` Eric Abrahamsen
  2015-09-11 16:59   ` Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Eric Abrahamsen @ 2015-09-11 16:20 UTC (permalink / raw)
  To: help-gnu-emacs

Dmitry Gutov <dgutov@yandex.ru> writes:

> Hi Eric,
>
> On 09/11/2015 06:38 PM, Eric Abrahamsen wrote:
>> I know we're supposed to move to automatically-generated changelogs Real
>> Soon Now, but in the meantime...
>
> We've transitioned to it already.

I thought I was paying attention! Sorry.

>> I'm having a bit of confusion about the best way to format git patches
>> for Emacs packages.
>
> Not sure about third-party packages, but for patches for Emacs, see
> CONTRIBUTE.

That clears up most of my questions, thank you.

I'd still be interested in seeing actual workflows, from whoever was
willing to share. I contribute occasionally to Gnus, Org and BBDB, and
each package seems to have its own particular relationship with the
general Emacs codebase.

But generally speaking, that answers the question. Thanks!

Eric




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: magit, changelogs and commit formatting
  2015-09-11 15:50 ` Dmitry Gutov
  2015-09-11 16:20   ` Eric Abrahamsen
@ 2015-09-11 16:59   ` Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2015-09-11 16:59 UTC (permalink / raw)
  To: help-gnu-emacs

> We've transitioned to it already.
                           ^^^^^^^

That's one way to put it ;-)


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-11 16:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-11 15:38 magit, changelogs and commit formatting Eric Abrahamsen
2015-09-11 15:50 ` Dmitry Gutov
2015-09-11 16:20   ` Eric Abrahamsen
2015-09-11 16:59   ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.