From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21465: [PATCH] CC-modes hierarchy Date: Mon, 14 Sep 2015 21:06:06 -0400 Message-ID: References: <20150914193349.13729.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442279249 11233 80.91.229.3 (15 Sep 2015 01:07:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 01:07:29 +0000 (UTC) Cc: 21465@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 15 03:07:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbeiK-0003uf-DL for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 03:07:16 +0200 Original-Received: from localhost ([::1]:44363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbeiJ-00048J-L9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 21:07:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbeiD-00041Y-8N for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 21:07:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbeiC-0001L8-Du for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 21:07:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbei6-0001HY-P6; Mon, 14 Sep 2015 21:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zbei6-0007rG-CN; Mon, 14 Sep 2015 21:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Tue, 15 Sep 2015 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21465 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21465-submit@debbugs.gnu.org id=B21465.144227916930096 (code B ref 21465); Tue, 15 Sep 2015 01:07:02 +0000 Original-Received: (at 21465) by debbugs.gnu.org; 15 Sep 2015 01:06:09 +0000 Original-Received: from localhost ([127.0.0.1]:60724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbehF-0007pL-4Q for submit@debbugs.gnu.org; Mon, 14 Sep 2015 21:06:09 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbehD-0007pC-EC for 21465@debbugs.gnu.org; Mon, 14 Sep 2015 21:06:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A2FgA731xV/0jo92hcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZAhE5Y0jhwjYYMzIoJ4AQEB X-IPAS-Result: A0A2FgA731xV/0jo92hcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZAhE5Y0jhwjYYMzIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="164849252" Original-Received: from 104-247-232-72.cpe.teksavvy.com (HELO ceviche.home) ([104.247.232.72]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Sep 2015 21:06:07 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2195166113; Mon, 14 Sep 2015 21:06:06 -0400 (EDT) In-Reply-To: <20150914193349.13729.qmail@mail.muc.de> (Alan Mackenzie's message of "14 Sep 2015 19:33:49 -0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106562 Archived-At: > c-after-font-lock-init surely isn't broken. c-after-change is ALWAYS on > after-change-functions. No, it's not. Not in my sm-awk-mode which derives from awk-mode. Or rather, I don't want it there and c-after-font-lock-init forces it down my throat again after I removed it. > Without it, CC Mode simply wouldn't function. It does. Besides, my patch does not remove c-after-change from after-change-functions. It just stops c-after-font-lock-init from re-adding it if someone decided to remove it. AFAIK c-after-change is never removed from after-change-functions by accident, so re-adding it blindly is a bug. >> AFAIK this patch has no issues w.r.t compatibility since it relies on >> behavior of define-derived-mode which has existed since "for ever". >> But it hasn't seen much testing, admittedly (except for my own personal use). > The question is, will XEmacs's define-derived-mode work? The text you quote is my answer to the question. > By the way, abbrev mode is used to expand "else" and "while" to themselves > + re-indentation. There are one or two other keywords handled likewise. > This isn't something either of us like, but doesn't seem urgent enough > to get round to fixing. Indeed, I don't think it's urgent to fix it, but I think it deserves a comment. Stefan