From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images Date: Sun, 20 Mar 2016 11:26:56 -0400 Message-ID: References: <20160320125720.21872.87876@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458487649 28809 80.91.229.3 (20 Mar 2016 15:27:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 15:27:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 16:27:17 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahfG9-0001KM-I0 for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 16:27:17 +0100 Original-Received: from localhost ([::1]:53315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfG8-0004Tl-OF for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 11:27:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfFy-0004Gt-NM for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahfFv-0003gR-I6 for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:27:06 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfFv-0003gN-Ds for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:27:03 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id u2KFRTha014275; Sun, 20 Mar 2016 11:27:29 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 5FDA7AE240; Sun, 20 Mar 2016 11:26:56 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 20 Mar 2016 14:49:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5616=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5616> : inlines <4536> : streams <1606023> : uri <2170628> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201939 Archived-At: >>> + (setq payload (ignore-errors >>> + (base64-decode-string payload)))) >> How 'bout with-demoted-errors? > I don't think the user cares that much -- if an image fails (whether to > downloading or being invalid), then eww should just continue signal that > in the document itself (with a broken image icon or the like). But > messaging is too much chatter. Hmm... I guess if payload is not a string at all because download failed, then indeed we have other indications of the problem and emitting a message would be redundant (and it's a normal occurrence anyway), but is it really "normal business" for payload to be a non-base64 string? I thought this would indicate some really unexpected circumstance. Stefan