From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images
Date: Sun, 20 Mar 2016 11:26:56 -0400 [thread overview]
Message-ID: <jwvh9g1yxxp.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <m3vb4huumr.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 20 Mar 2016 14:49:32 +0100")
>>> + (setq payload (ignore-errors
>>> + (base64-decode-string payload))))
>> How 'bout with-demoted-errors?
> I don't think the user cares that much -- if an image fails (whether to
> downloading or being invalid), then eww should just continue signal that
> in the document itself (with a broken image icon or the like). But
> messaging is too much chatter.
Hmm... I guess if payload is not a string at all because download
failed, then indeed we have other indications of the problem and
emitting a message would be redundant (and it's a normal occurrence
anyway), but is it really "normal business" for payload to be
a non-base64 string? I thought this would indicate some really
unexpected circumstance.
Stefan
next prev parent reply other threads:[~2016-03-20 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160320125720.21872.87876@vcs.savannah.gnu.org>
[not found] ` <E1ahcv2-0005hP-Mn@vcs.savannah.gnu.org>
2016-03-20 13:47 ` [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images Stefan Monnier
2016-03-20 13:49 ` Lars Magne Ingebrigtsen
2016-03-20 15:26 ` Stefan Monnier [this message]
2016-03-20 15:40 ` Lars Magne Ingebrigtsen
2016-03-20 16:12 ` Stefan Monnier
2016-03-20 16:41 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9g1yxxp.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.