From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Markus Triska <triska@metalevel.at>
Cc: 23871@debbugs.gnu.org, Phillip Lord <phillip.lord@russet.org.uk>
Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer
Date: Tue, 05 Jul 2016 18:00:26 -0400 [thread overview]
Message-ID: <jwvh9c36976.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <87h9c3g70o.fsf@metalevel.at> (Markus Triska's message of "Tue, 05 Jul 2016 22:32:55 +0200")
> One issue I noticed with the current undo system is that it behaves
> differently if the command that inserts text is invoked via a keyboard
> shortcut instead of via M-x ... RET.
This is probably because of the
buffer_before_last_command_or_undo == current_buffer
test, which is a naive/conservative test that just punts if there's
a buffer switch (in which case point_before_last_command_or_undo is
simply meaningless). And in this case there is, since the last command
was in another buffer (the last command was the RET you executed in the
minibuffer).
We could probably make it work by saving&restoring
buffer_before_last_command_or_undo and point_before_last_command_or_undo
around the minibuffer thingy. Or, making
point_before_last_command_or_undo into a buffer-local variable and get
rid of buffer_before_last_command_or_undo.
Stefan
next prev parent reply other threads:[~2016-07-05 22:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 21:47 bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Markus Triska
2016-06-30 16:38 ` Eli Zaretskii
2016-06-30 18:00 ` Markus Triska
2016-06-30 18:21 ` Eli Zaretskii
2016-06-30 18:52 ` Eli Zaretskii
2016-06-30 21:45 ` Phillip Lord
2016-07-01 6:31 ` Markus Triska
2016-07-01 7:25 ` Eli Zaretskii
2016-07-01 14:04 ` Phillip Lord
2016-07-01 20:38 ` Markus Triska
2016-07-01 22:12 ` Phillip Lord
2016-07-01 20:49 ` Markus Triska
2016-07-01 22:21 ` Phillip Lord
2016-07-02 5:35 ` Markus Triska
2016-07-02 7:35 ` Eli Zaretskii
2016-07-02 20:21 ` Phillip Lord
2016-07-02 20:53 ` Markus Triska
2016-07-03 3:33 ` Eli Zaretskii
2016-07-03 9:37 ` Phillip Lord
2016-07-03 10:08 ` Markus Triska
2016-07-03 12:55 ` Phillip Lord
2016-07-03 15:30 ` Eli Zaretskii
2016-07-03 20:21 ` Phillip Lord
2016-07-03 18:05 ` Markus Triska
2016-07-03 20:23 ` Phillip Lord
2016-07-03 22:03 ` Markus Triska
2016-07-04 14:38 ` Eli Zaretskii
2016-07-05 16:36 ` Eli Zaretskii
2016-07-05 19:44 ` Phillip Lord
2016-07-05 20:02 ` Markus Triska
2016-07-05 19:47 ` Markus Triska
2016-07-05 20:00 ` Eli Zaretskii
2016-07-03 15:12 ` Eli Zaretskii
2016-07-03 18:09 ` Markus Triska
2016-07-03 19:20 ` Eli Zaretskii
2016-07-03 20:37 ` Phillip Lord
2016-07-03 3:31 ` Eli Zaretskii
2016-07-03 9:39 ` Phillip Lord
2016-07-03 21:33 ` Stefan Monnier
2016-07-04 20:34 ` Phillip Lord
2016-07-04 21:32 ` Stefan Monnier
2016-07-05 8:43 ` Phillip Lord
2016-07-05 20:32 ` Markus Triska
2016-07-05 22:00 ` Stefan Monnier [this message]
2016-07-05 22:17 ` Phillip Lord
2016-07-05 22:09 ` Phillip Lord
2016-07-05 23:03 ` Markus Triska
2016-07-06 16:02 ` Phillip Lord
2016-07-06 17:59 ` Markus Triska
2016-08-12 23:03 ` npostavs
2016-08-13 8:02 ` Markus Triska
2016-07-05 8:46 ` undo refactoring Phillip Lord
2016-07-05 21:50 ` Stefan Monnier
2016-07-05 22:22 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9c36976.fsf-monnier+Inbox@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23871@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.