From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#22679: 25.0.91; ibuffer-do-shell-command-pipe truncate output Date: Fri, 19 Aug 2016 09:52:09 -0400 Message-ID: References: <7oa66k9es.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471614800 27197 195.159.176.226 (19 Aug 2016 13:53:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Aug 2016 13:53:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 22679@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 19 15:53:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bakEV-0006nd-KO for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Aug 2016 15:53:15 +0200 Original-Received: from localhost ([::1]:57427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bakES-0001bJ-SW for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Aug 2016 09:53:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bakEN-0001Zk-0Q for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 09:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bakEI-0001qa-1y for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 09:53:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bakEH-0001qW-V1 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 09:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bakEH-0007AX-K5 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Aug 2016 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22679-submit@debbugs.gnu.org id=B22679.147161474127508 (code B ref 22679); Fri, 19 Aug 2016 13:53:01 +0000 Original-Received: (at 22679) by debbugs.gnu.org; 19 Aug 2016 13:52:21 +0000 Original-Received: from localhost ([127.0.0.1]:33976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bakDc-00079c-Nl for submit@debbugs.gnu.org; Fri, 19 Aug 2016 09:52:20 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:60254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bakDb-00079V-Eb for 22679@debbugs.gnu.org; Fri, 19 Aug 2016 09:52:19 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u7JDqk05018925; Fri, 19 Aug 2016 09:52:48 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 004CDAE0E7; Fri, 19 Aug 2016 09:52:09 -0400 (EDT) In-Reply-To: (Tino Calancha's message of "Fri, 19 Aug 2016 17:33:00 +0900 (JST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5771=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5771> : inlines <5121> : streams <1686657> : uri <2270057> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122387 Archived-At: > - :modifier-p nil) > - (shell-command-on-region > - (point-min) (point-max) command)) > + :modifier-p nil > + :opstring "Shell command executed on" > + :modifier-p nil > + :before (funcall #'ibuffer--before-shell-command) > + :after (funcall #'ibuffer--after-shell-command)) > + (let ((out-buf (get-buffer "*Shell Command Output*"))) > + (with-current-buffer out-buf (goto-char (point-max))) > + (call-process-region (point-min) (point-max) command nil out-buf))) I haven't looked at the rest of your patch but this part looks wrong: the docstring indicates that `command' is expected to be a shell command whereas call-process-region expects an executable. Stefan