From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Feature request/RFC: proper highlighting of code embedded in comments Date: Mon, 17 Oct 2016 09:12:14 -0400 Message-ID: References: <930446db-6dad-72a0-d0cd-a0710e5c6ec3@mit.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1476710032 4514 195.159.176.226 (17 Oct 2016 13:13:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Oct 2016 13:13:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 17 15:13:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw7jW-0008Kj-MF for ged-emacs-devel@m.gmane.org; Mon, 17 Oct 2016 15:13:38 +0200 Original-Received: from localhost ([::1]:33005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw7jX-0007vc-PE for ged-emacs-devel@m.gmane.org; Mon, 17 Oct 2016 09:13:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw7jR-0007vW-40 for emacs-devel@gnu.org; Mon, 17 Oct 2016 09:13:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw7jM-0007Yr-60 for emacs-devel@gnu.org; Mon, 17 Oct 2016 09:13:33 -0400 Original-Received: from [195.159.176.226] (port=38559 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bw7jL-0007YC-VH for emacs-devel@gnu.org; Mon, 17 Oct 2016 09:13:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bw7iu-0004Cl-0T for emacs-devel@gnu.org; Mon, 17 Oct 2016 15:13:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:narrS3M76mBpcKzhvYInnkdeOZw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208353 Archived-At: > (font-lock-add-keywords nil '(("^ *>>> \\(.*\\)" (0 > (indirect-font-lock-highlighter 1 'python-mode))))) IIUC you additionally want to handle the "... " lines. > Stefan (and emacs-devel!), do you think I should add this to ELPA? Feel free. > Are there downsides I should be aware of? The usual: - running the major mode might run "side-effecting code" from the user's hook. I consider it a bug in the user's setup, but it does happen. - it fails to take into account local modifications of the font-lock rules. - ... Nothing too terrible, I think. Stefan