From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25312: Invalid options for slot ... Date: Sat, 31 Dec 2016 10:42:24 -0500 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483208837 9292 195.159.176.226 (31 Dec 2016 18:27:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 18:27:17 +0000 (UTC) Cc: Johan =?UTF-8?Q?Bockg=C3=A5rd?= To: 25312@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 31 19:27:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNON3-0001V4-R7 for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 19:27:10 +0100 Original-Received: from localhost ([::1]:45093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNON8-00062t-Qk for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 13:27:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNON1-00062X-TZ for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 13:27:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNON0-0006We-9j for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 13:27:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNOMw-0006Vq-H8; Sat, 31 Dec 2016 13:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cNOMw-0001yk-Bs; Sat, 31 Dec 2016 13:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bojohan@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2016 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-Received: via spool by submit@debbugs.gnu.org id=B.14832088077585 (code B ref -1); Sat, 31 Dec 2016 18:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Dec 2016 18:26:47 +0000 Original-Received: from localhost ([127.0.0.1]:33462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNOMh-0001yG-2l for submit@debbugs.gnu.org; Sat, 31 Dec 2016 13:26:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNOMe-0001y3-JV for submit@debbugs.gnu.org; Sat, 31 Dec 2016 13:26:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNOMX-0006Q7-U4 for submit@debbugs.gnu.org; Sat, 31 Dec 2016 13:26:39 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:33437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cNOMX-0006Pr-QM for submit@debbugs.gnu.org; Sat, 31 Dec 2016 13:26:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNOMV-0005mW-Ru for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 13:26:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNOMS-0006Ln-N3 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 13:26:35 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:56983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNOMS-0006Kh-HN for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 13:26:32 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id uBVIQSj0003716 for ; Sat, 31 Dec 2016 13:26:29 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 62426AE0F8; Sat, 31 Dec 2016 10:42:24 -0500 (EST) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1.5 X-NAI-Spam-Rules: 8 Rules triggered AFF_LOTTO_1_W_AFF_LOTTO_2=0.5, AFF_LOTTO_2=0.5, AFF_LOTTO_1=0.2, BEC_TRC1=0.1, BEC_TRC1_W_GEN_SPAM_FEATRE=0.1, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV5905=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5905> : inlines <5614> : streams <1727074> : uri <2350329> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127640 Archived-At: Package: Emacs Version: 25.1.50 The following commit: commit eb610f270ea919107b10bb8ece200a87abac6e0e Author: Johan Bockg=E5rd Date: Tue Oct 18 22:28:17 2016 +0200 =20=20=20=20 cl-defstruct: Fix debug spec and check of slot options =20=20=20=20=20=20=20=20 * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Improve checking of sl= ot option syntax. Fix debug spec. (Bug#24700) Is a bit too strict: it causes various packages (such as the GNU ELPA packages `xpm`, `dbus-codegen`, and `gnorb`) to signal an error during compilation. This is typically because they use (cl-defstruct ... (slotname :read-only t) ...) instead of (cl-defstruct ... (slotname nil :read-only t) ...) We should fix those packages, but they worked just fine until now despite this mistake, so we shouldn't break them gratuitously. IOW the error we signal should be changed to a warning, and it should be made more clear, since I expect many coders won't understand what it means (they'll look at their slot definition and will think "Huh? I only use the option :read-only, and that should be valid!"). Stefan In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.6) of 2016-08-07 built on alfajor Repository revision: 1662ba23be7859f61e3617e323f3234c5f82507c Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Debian GNU/Linux testing (stretch) Recent messages: Warning: turn-on-eldoc-mode is obsolete! Warning: hide-sublevels is obsolete! Mark saved where search started Reverting file ~/src/emacs/trunk/lisp/emacs-lisp/cl-macs.el... Warning: turn-on-eldoc-mode is obsolete! Warning: hide-sublevels is obsolete! Reverting file ~/src/emacs/trunk/lisp/emacs-lisp/cl-macs.el...done Mark saved where search started [2 times] Undo! Mark set [2 times] Configured using: 'configure -C --enable-checking --enable-check-lisp-object-type 'CFLAGS=3D-Wall -g3 -Og -Wno-pointer-sign' PKG_CONFIG_PATH=3D/home/monnier/lib/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: fr_CH.UTF-8 locale-coding-system: utf-8-unix Major mode: InactiveMinibuffer Minor modes in effect: dired-omit-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t electric-pair-mode: t global-reveal-mode: t reveal-mode: t auto-insert-mode: t savehist-mode: t minibuffer-electric-default-mode: t global-compact-docstrings-mode: t url-handler-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/monnier/src/emacs/elpa/packages/svg/svg hides /home/monnier/src/emacs= /work/lisp/svg /home/monnier/src/emacs/elpa/packages/ada-mode/ada-mode hides /home/monnier= /src/emacs/work/lisp/progmodes/ada-mode /home/monnier/src/emacs/elpa/packages/ada-mode/ada-stmt hides /home/monnier= /src/emacs/work/lisp/progmodes/ada-stmt /home/monnier/src/emacs/elpa/packages/ada-mode/ada-prj hides /home/monnier/= src/emacs/work/lisp/progmodes/ada-prj /home/monnier/src/emacs/elpa/packages/ada-mode/ada-xref hides /home/monnier= /src/emacs/work/lisp/progmodes/ada-xref /home/monnier/src/emacs/elpa/packages/landmark/landmark hides /home/monnier= /src/emacs/work/lisp/obsolete/landmark /home/monnier/src/emacs/elpa/packages/crisp/crisp hides /home/monnier/src/e= macs/work/lisp/obsolete/crisp Features: (mail-extr emacsbug bug-reference inline mh-e mh-compat mh-acros mh-buffers mh-loaddefs mode-local dunnet dired-x tabify imenu man ox-latex ox-icalendar ox-html ox-ascii ox-publish ox org-protocol org-mouse org-mobile org-agenda org-indent org-feed org-crypt org-capture org-attach org-id org-element org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs battery typer-mode beancount ido conf-mode eieio-opt rect thai-util thai-word package-x sh-script sort mpc quail log-view help-fns radix-tree cal-french diary-lib diary-loaddefs cal-move cal-menu calendar cal-loaddefs reftex-dcr reftex reftex-loaddefs reftex-vars tex-mode latexenc bbdb-com bbdb timezone make-mode whitespace sm-c-mode xscheme warnings unsafep trace testcover shadow scheme re-builder profiler inf-lisp ielm ert pp find-func elp edebug cl-indent map epa-file descr-text autorevert filenotify doc-view jka-compr image-mode dabbrev ffap grep misearch multi-isearch shell pcomplete debug log-edit message sendmail subr-x puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log executable copyright smerge-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir ewoc vc vc-dispatcher cus-edit cus-start cus-load wid-edit vc-git diff-mode filecache caml tuareg_indent tuareg speedbar sb-image ezimage dframe compile comint ansi-color ring smie caml-help caml-types caml-emacs server time-date noutline outline easy-mmode flyspell ispell checkdoc thingatpt load-dir elec-pair reveal autoinsert proof-site proof-autoloads cl pg-vars savehist minibuf-eldef disp-table compact-docstrings kotl-loaddefs advice info realgud-recursive-autoloads finder-inf url-auth package epg-config url-handlers url-parse auth-source eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib bbdb-loaddefs mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 1307203 271855) (symbols 24 52524 2) (miscs 20 20865 2370) (strings 16 191631 26349) (string-bytes 1 5685348) (vectors 8 105800) (vector-slots 4 3443686 341944) (floats 8 766 1944) (intervals 28 200743 393) (buffers 520 149) (heap 1024 1428477 2044))