From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: How can I undo a change from a modification-hook? Date: Wed, 26 Apr 2017 09:52:04 -0400 Message-ID: References: <2448005f-9fc4-78b2-3203-9fc8204f6f5b@mit.edu> <87fd6638-f46a-95f2-8b70-f271f5daeb63@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493214849 11588 195.159.176.226 (26 Apr 2017 13:54:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Apr 2017 13:54:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 26 15:54:05 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NOP-0002vj-QB for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2017 15:54:05 +0200 Original-Received: from localhost ([::1]:55360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NOV-0006Zo-Gl for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2017 09:54:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NMg-0005qp-1K for emacs-devel@gnu.org; Wed, 26 Apr 2017 09:52:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3NMb-0004WI-4Q for emacs-devel@gnu.org; Wed, 26 Apr 2017 09:52:18 -0400 Original-Received: from [195.159.176.226] (port=57237 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3NMZ-0004Uf-Qr for emacs-devel@gnu.org; Wed, 26 Apr 2017 09:52:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d3NMR-0000I4-Ky for emacs-devel@gnu.org; Wed, 26 Apr 2017 15:52:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hgR+zik7FDGBhJ8FOdnAXXXDIzE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214309 Archived-At: >> [ and while you're there, check that the beg/end/len is within the >> announces beg/end stashed earlier, and if it's not just don't do >> anything since it means the stash buffer-undo-list is likely >> unrelated. ] > This part worries me. Could you clarify when this would happen? In rare corner cases (most of them bugs). > Not doing anything is risky, because it puts the buffer in an inconsistent > state wrt the subprocess :/ In the case of PG, I'd suggest you treat such a case as a non-whitespace change. Stefan