From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode Date: Tue, 30 May 2017 00:09:19 -0400 Message-ID: References: <20170529235539.23360.19169@vcs0.savannah.gnu.org> <20170529235540.48D1C20ACA@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496117377 4692 195.159.176.226 (30 May 2017 04:09:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 04:09:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 06:09:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFYTL-0000y0-Pz for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 06:09:31 +0200 Original-Received: from localhost ([::1]:51369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFYTN-0003o7-GT for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 00:09:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFYTH-0003o1-Jx for emacs-devel@gnu.org; Tue, 30 May 2017 00:09:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFYTB-0007Y2-70 for emacs-devel@gnu.org; Tue, 30 May 2017 00:09:27 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFYTB-0007Xs-1k for emacs-devel@gnu.org; Tue, 30 May 2017 00:09:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AWBQCh7yxZ/32TCkxcGgEBAQECAQEBAQgBAQEBg1WKbYV/kR4Bl1wchgIEAgKCWEQUAQIBAQEBAQEBayiFGQZWIxALNBIUGA2KYa5Ui0YBAQEHKItghTWFBx8FniOVFgGJDIZ8kwqBRDYhgQowIQgwhX6BZiSKLwEBAQ X-IPAS-Result: A0AWBQCh7yxZ/32TCkxcGgEBAQECAQEBAQgBAQEBg1WKbYV/kR4Bl1wchgIEAgKCWEQUAQIBAQEBAQEBayiFGQZWIxALNBIUGA2KYa5Ui0YBAQEHKItghTWFBx8FniOVFgGJDIZ8kwqBRDYhgQowIQgwhX6BZiSKLwEBAQ X-IronPort-AV: E=Sophos;i="5.38,417,1491278400"; d="scan'208";a="313928412" Original-Received: from 76-10-147-125.dsl.teksavvy.com (HELO ceviche.home) ([76.10.147.125]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 May 2017 00:09:20 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id C1CE1662E6; Tue, 30 May 2017 00:09:19 -0400 (EDT) In-Reply-To: <20170529235540.48D1C20ACA@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Mon, 29 May 2017 19:55:39 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215341 Archived-At: > ((memq eldoc-documentation-function '(nil ignore)) [...] > + (unless (memq eldoc-documentation-function '(nil ignore)) It'd probably be best to move this out into its own function so if we ever change the test at one spot, we also change the other spot accordingly. Stefan