all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers
Date: Tue, 19 Sep 2017 08:42:18 -0400	[thread overview]
Message-ID: <jwvh8vyamw3.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87ingfcrf6.fsf@ericabrahamsen.net

> This was fallout from 9b980e269, aka bug #28412, where now we prompt for
> buffers that have functions in the `write-contents-functions' hook.

Ah, I see I was looking at the wrong version of the code, sorry.
So the question becomes: why does " *Code-Fontify*" have a non-nil
write-contents-functions?

Looking at ggtags.el, I also wonder why the buffer survives the call to
ggtags-fontify-code.  I would have expected ggtags-fontify-code to look
more like:

(cl-defun ggtags-fontify-code (code &optional (mode major-mode))
  (cl-check-type mode function)
  (cl-typecase code        ;; FIXME: Using `stringp` is more efficient.
    ((not string) code)
    (string
     (with-temp-buffer
       (insert code)
       ;; FIXME: `delay-mode-hooks' needs a comment
       (delay-mode-hooks (funcall mode))
       (font-lock-ensure)
       (buffer-string)))))


-- Stefan




  reply	other threads:[~2017-09-19 12:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170918202953.21378.63492@vcs0.savannah.gnu.org>
     [not found] ` <20170918202955.5043420AC4@vcs0.savannah.gnu.org>
2017-09-19  2:44   ` [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Stefan Monnier
2017-09-19  3:12     ` Eric Abrahamsen
2017-09-19 12:42       ` Stefan Monnier [this message]
2017-09-19 13:25         ` Kaushal Modi
2017-09-19 15:44           ` Eric Abrahamsen
2017-09-19 15:50             ` Kaushal Modi
2017-09-19 15:53             ` Stefan Monnier
2017-09-19 16:03               ` Eric Abrahamsen
2017-09-19 15:37         ` Leo Liu
2017-09-19 15:56           ` Stefan Monnier
2017-09-19 10:48     ` Kaushal Modi
2017-09-19 12:08       ` Stefan Monnier
2017-09-19 12:26         ` Kaushal Modi
2017-09-19 18:13           ` Eric Abrahamsen
2017-09-20  2:10             ` Kaushal Modi
2017-09-20  7:16               ` Andreas Schwab
2017-09-20 17:14               ` Eric Abrahamsen
2017-09-21  8:01                 ` Eli Zaretskii
2017-09-21 19:57                   ` Eric Abrahamsen
2017-09-21 20:10                     ` Kaushal Modi
2017-09-21 22:53                       ` Eric Abrahamsen
2017-09-22  6:54                     ` Eli Zaretskii
2017-09-22 15:52                       ` Eric Abrahamsen
2017-09-22 16:18                         ` Stefan Monnier
2017-09-22 16:54                           ` Eric Abrahamsen
2017-09-22 19:03                             ` Stefan Monnier
2017-09-22 23:27                               ` Eric Abrahamsen
2017-09-23  2:43                                 ` Stefan Monnier
2017-09-24 19:25                           ` Eric Abrahamsen
2017-09-24 19:29                             ` Stefan Monnier
2017-09-24 20:59                               ` Eric Abrahamsen
2017-09-22 17:21                         ` Eli Zaretskii
2017-09-22 17:57                           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh8vyamw3.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.