From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30635: No compiler warning if code forgets to require cl-lib Date: Thu, 22 Mar 2018 18:19:29 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521757088 24700 195.159.176.226 (22 Mar 2018 22:18:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 22:18:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30635@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 23:18:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez8X6-0006LT-5G for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 23:18:04 +0100 Original-Received: from localhost ([::1]:35142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez8Z9-0006zV-GU for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 18:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez8Z3-0006yE-CU for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 18:20:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez8Z0-0005Xb-7d for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 18:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ez8Z0-0005XV-3b for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 18:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ez8Yz-00015S-QB for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 18:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2018 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30635-submit@debbugs.gnu.org id=B30635.15217571734137 (code B ref 30635); Thu, 22 Mar 2018 22:20:01 +0000 Original-Received: (at 30635) by debbugs.gnu.org; 22 Mar 2018 22:19:33 +0000 Original-Received: from localhost ([127.0.0.1]:48206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez8YX-00014e-Kp for submit@debbugs.gnu.org; Thu, 22 Mar 2018 18:19:33 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez8YV-00014V-4J for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 18:19:31 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2MMJTcv005730; Thu, 22 Mar 2018 18:19:30 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 99DD0604C8; Thu, 22 Mar 2018 18:19:29 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 17:53:01 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781972> : uri <2613033> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144537 Archived-At: >>>> There's no compiler warning if a library uses cl-lib without requiring= it. >>>> I assume this is because bytecomp.el requires cl-lib. >>> Should we apply the patch below? >> Works for me, thanks. > Doesn't work for me, OTOH: [...] > and if you look at `dir-locals-read-from-dir`, you'll see that it does > (require 'map) and then uses its `map-merge(-with)`. And if I tweak dir-locals-read-from-dir so it doesn't require `map`, and then try to compile a file like gnus-cloud.el where I removed all the `require`s, I still get: % src/emacs --batch --eval "(eval-after-load 'cl-lib '(debug t))" -f b= atch-byte-compile lisp/gnus/gnus-cloud.el=20=20 Debugger entered--beginning evaluation of function call form: (lambda nil (debug t))() [...] require(cl-lib) byte-code("\300\301!\210\300\302!\210\300\303!\207" [require cl-lib m= acroexp gv] 2) cl--defsubst-expand((cl-x) (cl-block epg-context-armor (or (cl--struc= t-epg-context-p cl-x) (signal 'wrong-type-argument (list 'epg-context cl-x)= )) (aref cl-x 4)) nil nil nil context) epg-context-armor--cmacro((epg-context-armor context) context) apply(epg-context-armor--cmacro (epg-context-armor context) context) gv-get((epg-context-armor context) #f(compiled-function (getter sette= r) #)) [...] macroexpand-all((defalias 'gnus-cloud-encode-data ...) ...) [...] byte-compile-recurse-toplevel((defun gnus-cloud-encode-data ...) ...) The end result is better tho; if I then add a call to `cl-every` into that file, I do get a warning of the form: gnus/gnus-cloud.el:512:1:Warning: the function =E2=80=98cl-every=E2=80= =99 might not be defined at runtime. So I pushed the previous two patches to master, since I think they at least partly fix this bug. Stefan