all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 31118@debbugs.gnu.org
Subject: bug#31118: 27.0.50; Can't load/compile websocket in 32bit master
Date: Wed, 18 Apr 2018 08:22:50 -0400	[thread overview]
Message-ID: <jwvh8o8embg.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <a8ac1876-6a42-cc2e-e817-7ffd26b96b4d@cs.ucla.edu> (Paul Eggert's message of "Tue, 17 Apr 2018 16:53:32 -0700")

> Something like the attached patch, perhaps?

That might be good enough.


        Stefan


> From eb2fa1a00c5c85aced40900b59183dc03d822958 Mon Sep 17 00:00:00 2001
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 17 Apr 2018 16:52:04 -0700
> Subject: [PATCH] Tell user about read-integer-overflow-as-float
>
> * src/lread.c (string_to_number): Suggest
> read-integer-overflow-as-float in signal message.
> Suggested by Stefan Monnier (Bug#31118#58).
> ---
>  src/lread.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/lread.c b/src/lread.c
> index 6eda740540..16e34aff0c 100644
> --- a/src/lread.c
> +++ b/src/lread.c
> @@ -3797,7 +3797,12 @@ string_to_number (char const *string, int base, int flags)
>  	value = n;
>  
>        if (! (state & DOT_CHAR) && ! (flags & S2N_OVERFLOW_TO_FLOAT))
> -	xsignal1 (Qoverflow_error, build_string (string));
> +	{
> +	  AUTO_STRING (fmt, ("%s is out of fixnum range; "
> +			     "maybe set `read-integer-overflow-as-float'?"));
> +	  xsignal1 (Qoverflow_error,
> +		    CALLN (Fformat_message, fmt, build_string (string)));
> +	}
>      }
>  
>    /* Either the number uses float syntax, or it does not fit into a fixnum.





  reply	other threads:[~2018-04-18 12:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  3:03 bug#31118: 27.0.50; Can't load/compile websocket in 32bit master Stefan Monnier
2018-04-10 22:41 ` Paul Eggert
2018-04-11  1:56   ` Stefan Monnier
2018-04-11  8:07     ` Paul Eggert
     [not found]       ` <mvmwoxe40f3.fsf@suse.de>
2018-04-11  8:35         ` Paul Eggert
2018-04-11 12:19       ` Stefan Monnier
2018-04-11 12:47         ` Basil L. Contovounesios
2018-04-11 16:22         ` Paul Eggert
2018-04-11 18:37           ` Stefan Monnier
2018-04-11 19:47             ` Glenn Morris
2018-04-15 22:11             ` Paul Eggert
2018-04-16  1:26               ` Stefan Monnier
2018-04-17  7:50                 ` Paul Eggert
2018-04-17 12:18                   ` Stefan Monnier
2018-04-17 23:53                     ` Paul Eggert
2018-04-18 12:22                       ` Stefan Monnier [this message]
2018-04-18 19:50                         ` Paul Eggert
2018-04-11 16:41         ` Eli Zaretskii
2018-04-11 18:38           ` Stefan Monnier
2018-04-12 12:50             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh8o8embg.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=31118@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.