Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

[Stefan Monnier]

> +(defun xref-find-definitions-at-mouse (event)
> +  "Find the definition of identifier at or around mouse click.
> +This command is intended to be bound to a mouse event."
> +  (interactive "e")

If we use

    (defun xref-find-definitions-at-mouse (&optional event)
      "Find the definition of identifier at or around mouse click.
    This command is intended to be bound to a mouse event."
      (interactive (list last-nonmenu-event))

then this command will also work with non-mouse events.


        Stefan


PS: No, I don't know why we usually use last-nonmenu-event rather
  than last-command-event or last-input-event for those commands.

Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

[Tobias Gerdin]

Den 2018-07-09 kl. 15:55, skrev Stefan Monnier:

>> +(defun xref-find-definitions-at-mouse (event)
>> +  "Find the definition of identifier at or around mouse click.
>> +This command is intended to be bound to a mouse event."
>> +  (interactive "e")
> If we use
>
>      (defun xref-find-definitions-at-mouse (&optional event)
>        "Find the definition of identifier at or around mouse click.
>      This command is intended to be bound to a mouse event."
>        (interactive (list last-nonmenu-event))
>
> then this command will also work with non-mouse events.
>
>
>          Stefan
>
>
> PS: No, I don't know why we usually use last-nonmenu-event rather
>    than last-command-event or last-input-event for those commands.
I'm afraid I do not see the point of making it work without mouse 
events? Would that be in the interest of merging it with 
'xref-find-definitions' somehow?

-Tobias

Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

[Stefan Monnier]

> I'm afraid I do not see the point of making it work without mouse events?

I look at it from the other side: what's the point of making it work
only when bound to a mouse event?

> Would that be in the interest of merging it with
> 'xref-find-definitions' somehow?

I haven't made the effort to try and understand what's the real
difference between xref-find-definitions and
xref-find-definitions-at-mouse, so I can't really answer.

Maybe they can be merged, but maybe they are meant to behave differently
(e.g. xref-find-definitions-at-mouse should never prompt the user about
which identifier to use?).


        Stefan

Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

[Helmut Eller]

On Mon, Jul 09 2018, Stefan Monnier wrote:

> Maybe they can be merged, but maybe they are meant to behave differently
> (e.g. xref-find-definitions-at-mouse should never prompt the user about
> which identifier to use?).

For "mouse mode" it might also be more natural to use an actual popup
menu instead of the *xref* buffer to display a list of choices.

Helmut

Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'

[Tobias Gerdin]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

> 
> On Mon, Jul 09 2018, Stefan Monnier wrote:
> 
> > Maybe they can be merged, but maybe they are meant to behave differently
> > (e.g. xref-find-definitions-at-mouse should never prompt the user about
> > which identifier to use?).
> 
> For "mouse mode" it might also be more natural to use an actual popup
> menu instead of the *xref* buffer to display a list of choices.
> 
> Helmut

Good idea, I will try to look in to this!
-Tobias

[-- Attachment #2: Type: text/html, Size: 795 bytes --]