From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse' Date: Mon, 09 Jul 2018 16:25:03 -0400 Message-ID: References: <20180707090050.359.98328@vcs0.savannah.gnu.org> <20180707090052.4B7F9204E8@vcs0.savannah.gnu.org> <6821c870-e955-ec96-dd73-a2950a0ba4f6@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531167830 20189 195.159.176.226 (9 Jul 2018 20:23:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2018 20:23:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 09 22:23:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcchG-00058V-11 for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 22:23:46 +0200 Original-Received: from localhost ([::1]:44232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccjM-0006TM-RH for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 16:25:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccii-0006T6-7f for emacs-devel@gnu.org; Mon, 09 Jul 2018 16:25:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fccie-0001rk-8h for emacs-devel@gnu.org; Mon, 09 Jul 2018 16:25:16 -0400 Original-Received: from [195.159.176.226] (port=50776 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fccie-0001r0-07 for emacs-devel@gnu.org; Mon, 09 Jul 2018 16:25:12 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fccgT-0004MM-SS for emacs-devel@gnu.org; Mon, 09 Jul 2018 22:22:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:3r0Ql6YDirB+yeOxnzU2KXnH1RA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227181 Archived-At: > I'm afraid I do not see the point of making it work without mouse events? I look at it from the other side: what's the point of making it work only when bound to a mouse event? > Would that be in the interest of merging it with > 'xref-find-definitions' somehow? I haven't made the effort to try and understand what's the real difference between xref-find-definitions and xref-find-definitions-at-mouse, so I can't really answer. Maybe they can be merged, but maybe they are meant to behave differently (e.g. xref-find-definitions-at-mouse should never prompt the user about which identifier to use?). Stefan