From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Thu, 14 Mar 2019 09:34:07 -0400 Message-ID: References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28936"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Nicolas Petton , 34852@debbugs.gnu.org, "Miguel V. S. Frasson" To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 14:54:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4QoG-0007L5-Aq for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 14:54:12 +0100 Original-Received: from localhost ([127.0.0.1]:37684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4QoF-0006WM-9X for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 09:54:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4Qhk-0000XA-SX for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 09:47:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4QVj-0006gU-SD for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 09:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4QVi-0006fg-Ka for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 09:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4QVi-00076Q-4k for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155257045427238 (code B ref 34852); Thu, 14 Mar 2019 13:35:02 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 14 Mar 2019 13:34:14 +0000 Original-Received: from localhost ([127.0.0.1]:43113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4QUv-00075F-W8 for submit@debbugs.gnu.org; Thu, 14 Mar 2019 09:34:14 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4QUs-000754-2j for 34852@debbugs.gnu.org; Thu, 14 Mar 2019 09:34:12 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x2EDY8T3006526; Thu, 14 Mar 2019 09:34:08 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id F0E7A6AB6A; Thu, 14 Mar 2019 09:34:07 -0400 (EDT) In-Reply-To: <87va0lmwlg.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Mar 2019 14:09:15 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6503=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6503> : inlines <7033> : streams <1815684> : uri <2812597> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156328 Archived-At: Yet another approach might be to make an exception in seq-contains if the returned element is nil (and return something else in that case). E.g. diff --git a/lisp/emacs-lisp/seq.el b/lisp/emacs-lisp/seq.el index 4a811d7895..d2398eb588 100644 --- a/lisp/emacs-lisp/seq.el +++ b/lisp/emacs-lisp/seq.el @@ -360,7 +360,7 @@ seq-sort-by Equality is defined by TESTFN if non-nil or by `equal' if nil." (seq-some (lambda (e) (when (funcall (or testfn #'equal) elt e) - e)) + (or e t))) sequence)) (cl-defgeneric seq-set-equal-p (sequence1 sequence2 &optional testfn) -- Stefan