From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Fri, 22 Mar 2019 15:32:53 -0400 Message-ID: References: <8336o1e33w.fsf@gnu.org> <83r2blcdj2.fsf@gnu.org> <83h8cgc7ih.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61522"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34723@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 22 20:41:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7Q3A-000FqA-Li for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Mar 2019 20:41:56 +0100 Original-Received: from localhost ([127.0.0.1]:33797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7Q39-0000mR-G9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Mar 2019 15:41:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7Q2n-0000VB-9o for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 15:41:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7Pva-0001mb-3o for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 15:34:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7PvW-0001gT-Bd for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 15:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h7PvW-0004YG-11 for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2019 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155328318517435 (code B ref 34723); Fri, 22 Mar 2019 19:34:01 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 22 Mar 2019 19:33:05 +0000 Original-Received: from localhost ([127.0.0.1]:54693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Pub-0004X9-55 for submit@debbugs.gnu.org; Fri, 22 Mar 2019 15:33:05 -0400 Original-Received: from alt34.smtp-out.videotron.ca ([24.53.0.23]:35233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7PuX-0004Wd-GY for 34723@debbugs.gnu.org; Fri, 22 Mar 2019 15:33:03 -0400 Original-Received: from fmsmemgm.homelinux.net ([24.203.163.157]) by Videotron with SMTP id 7PuPhBFmxuR9T7PuQh0pxX; Fri, 22 Mar 2019 15:32:55 -0400 X-Authority-Analysis: v=2.3 cv=N+kH6V1B c=1 sm=1 tr=0 a=271BjrAMcq2W4n6OKK/JJg==:117 a=271BjrAMcq2W4n6OKK/JJg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=NTGMnVQrEZIA:10 a=livkJCoIFQ6mIVuaV2cA:9 a=QEXdDO2ut3YA:10 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 61CFFAEC22; Fri, 22 Mar 2019 15:32:53 -0400 (EDT) In-Reply-To: (Charles A. Roelli's message of "Sat, 16 Mar 2019 21:21:40 +0100") X-CMAE-Envelope: MS4wfCihn9S1Ojw08dD55OrzwjskVrA5MyISlh4rd1fZxBH1iviP0TaDBUIDnMz8wJGk163Hrzia4HuN5UcUt7noLVeQoKQZ5vxuDYcfchtfD9+Ci/DfXINQ rkuU6Prjuxdgt/vsK0NCh/T2pF/BdgIE/cF+NswYX3mAXzAK7yDcqigN5iOqPkA35242pA3MX2B5gLWcEoB71DN7b6QYsF+Ofo0g5euoFUt9ojjz8fw3l3dv XeCrQAmydQXEu6WlhV2uydh1+plvMR5Z2D8Ue3+I+FE= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156626 Archived-At: >> Sometimes it's also not eager enough (if the hunk is longer than half of >> the screen, it shouldn't just recenter but it should likely scroll >> further so that more than half of the screen shows the hunk). > Yes. In that specific case, we could call (recenter 0) to make more > (or all of) the hunk visible. I think in some cases I'd like it, yes. But would you? I thought you didn't want recentering in next-hunk at all=E2=80=BD Also I'm not sure if it would annoy me more often than not, which is probably why I haven't bothered to try and code it up. >> Did that only refer to `scroll-conservatively`? If not, could you >> clarify which scroll-related variable setting is not respected, >> and when? > Hm, I'm not sure if there was another variable that the behavior > affects (can't find one now). This is no big issue; it's an argument > for making the behavior customizable. Yes, feel free to add such a custom var. Stefan