From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display Date: Sat, 15 Jun 2019 06:32:41 -0400 Message-ID: References: <20190614211218.5886.59920@vcs0.savannah.gnu.org> <20190614211219.59B5721012@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60187"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 15 12:33:13 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hc5zk-000FWE-1v for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 12:33:12 +0200 Original-Received: from localhost ([::1]:59680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc5zi-0006jm-JE for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 06:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41947) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc5zV-0006j8-OC for emacs-devel@gnu.org; Sat, 15 Jun 2019 06:32:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc5zN-0000t2-RZ for emacs-devel@gnu.org; Sat, 15 Jun 2019 06:32:53 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9331) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hc5zN-0000pV-Ff for emacs-devel@gnu.org; Sat, 15 Jun 2019 06:32:49 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 14C9F810FA; Sat, 15 Jun 2019 06:32:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CFC3180DBF; Sat, 15 Jun 2019 06:32:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560594764; bh=DXYcek8/3FNe1m4RBe2c6uZiwysFvxdEfEPWbay6wOU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PV2DeY0M5WXJ+LGnI+tR95e/EDDvUN7RmzpkWTVerHCb/isztN1jOLTq4+0fDnnsd YhDXD3lB/qst3/WMqwjjFTvblS1fbpsc2E1XcZtiXClLVEpbkEQRe6ZKRTjt1hU51S KojiDEt2oGlug0U9XisD0eAkHXRdfD7KTa4cGz1bfNsLrtFUzqCq+dq/Y+TQgvZj6X IrV2JnMijdEHn4IP++FUctq3BuUK6GlYuFi0mUaRkQ0dfJb7TK/5VMwRbSxDpvJJtp NFA2bKCdZ8ydkjVlOxa+G9VBSeQ0X5YbpX0eksCfGGJnYAZMAlkLZlKgsIU0aqMsiV FvUKX286t2Zkw== Original-Received: from alfajor (unknown [195.69.9.33]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B333C120329; Sat, 15 Jun 2019 06:32:43 -0400 (EDT) In-Reply-To: <20190614211219.59B5721012@vcs0.savannah.gnu.org> (Thomas Fitzsimmons's message of "Fri, 14 Jun 2019 17:12:19 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237659 Archived-At: > + (unless (eq diary-display-function 'diary-fancy-display) > + (warn (format > + (concat "Excorporate diary support needs diary-fancy-display" > + " but diary-display-function is currently %S; overriding") > + diary-display-function)) > + (customize-set-variable 'diary-display-function 'diary-fancy-display)) The warning is good, but I think that unilaterally overriding the user's choice is a bad idea. For example, it prevents using a tweaked version of `diary-fancy-display`. Stefan