From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display
Date: Sat, 15 Jun 2019 06:32:41 -0400 [thread overview]
Message-ID: <jwvh88rta58.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20190614211219.59B5721012@vcs0.savannah.gnu.org> (Thomas Fitzsimmons's message of "Fri, 14 Jun 2019 17:12:19 -0400 (EDT)")
> + (unless (eq diary-display-function 'diary-fancy-display)
> + (warn (format
> + (concat "Excorporate diary support needs diary-fancy-display"
> + " but diary-display-function is currently %S; overriding")
> + diary-display-function))
> + (customize-set-variable 'diary-display-function 'diary-fancy-display))
The warning is good, but I think that unilaterally overriding the user's
choice is a bad idea.
For example, it prevents using a tweaked version of `diary-fancy-display`.
Stefan
next parent reply other threads:[~2019-06-15 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190614211218.5886.59920@vcs0.savannah.gnu.org>
[not found] ` <20190614211219.59B5721012@vcs0.savannah.gnu.org>
2019-06-15 10:32 ` Stefan Monnier [this message]
2019-06-15 13:13 ` [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display Thomas Fitzsimmons
2019-06-16 22:56 ` Stefan Monnier
2019-06-17 22:18 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh88rta58.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.