From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17180: [PATCH] eldoc doesn't find docstrings for variable aliases Date: Wed, 26 Jun 2019 10:35:42 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223417"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Josh , 17180@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 16:36:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg924-000vs0-RK for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 16:36:20 +0200 Original-Received: from localhost ([::1]:40718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg923-0003t4-RO for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 10:36:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg91v-0003su-AU for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:36:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg91t-0000tW-AA for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:36:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg91m-0000oT-2M for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:36:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg91l-0007CZ-Ub for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17180 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy fixed Original-Received: via spool by 17180-submit@debbugs.gnu.org id=B17180.156155975527657 (code B ref 17180); Wed, 26 Jun 2019 14:36:01 +0000 Original-Received: (at 17180) by debbugs.gnu.org; 26 Jun 2019 14:35:55 +0000 Original-Received: from localhost ([127.0.0.1]:36680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg91f-0007C1-FQ for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:35:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg91e-0007Bk-1W for 17180@debbugs.gnu.org; Wed, 26 Jun 2019 10:35:54 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B0B3B8116F; Wed, 26 Jun 2019 10:35:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 54F098030C; Wed, 26 Jun 2019 10:35:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1561559743; bh=a6ni2JaiCQwKF/oCObVw1mhQyO65fs0Yj7fyVB2PlfI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ek0UtgpyVeD8vfe1IvRs7HzxEkyeceCR0fQTXZJHCPspUM6YnUQgWQ/TRY2736ioT 5i6z6rgQezM028dESbLUEegoizLY9Khqz3ALW45HVCZx5ESCQv9ZVdcf80HeEaJi52 0xKhUNwYoAS+/jqQbTGQ6F1o0PC/vz9RLwDoh0sq2QD4GvDjx0xk+1h05JjpOoHKl+ /JFzrSx7ZDoVHTaXSQblMWiSUSsJo7ud4TZjjauCsSX5CQezkXAJA+l0M2dL1DQzNS o08VS3onC0g61NgfEWzveTY3F6RSy5nCLG6ccnV1dMLWIYcwBx3ypVwlJOoEHNDuU3 8OqTZSVgPG6Zw== Original-Received: from pastel (76-10-151-214.dsl.teksavvy.com [76.10.151.214]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 238A812000B; Wed, 26 Jun 2019 10:35:43 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 26 Jun 2019 16:27:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161501 Archived-At: > + /* If we don't have any documentation for this symbol, try to see whether > + it's an indirect variable and get the documentation from there instead. */ > + if (NILP (tem)) > + { > + Lisp_Object indirect = Findirect_variable (symbol); > + if (!NILP (indirect)) > + tem = Fget (indirect, prop); > + } In theory documentation-property can be used for any property, so it's not necessarily specific to variables. IOW I think we should only do that if `prop` is `variable-documentation`. Stefan