From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37176@debbugs.gnu.org, Jean Louis <bugs@gnu.support>
Subject: bug#37176: 27.0.50; recursive-edit interrupted by invokation of emacsclient
Date: Sun, 25 Aug 2019 14:08:01 -0400 [thread overview]
Message-ID: <jwvh865qfwd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8336hpiv7l.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Aug 2019 10:02:22 +0300")
> Stefan, this is the result of your code from 13 years ago in
> server.el:
>
> (when (> (recursion-depth) 0)
> ;; We're inside a minibuffer already, so if the emacs-client is trying
> ;; to open a frame on a new display, we might end up with an unusable
> ;; frame because input from that display will be blocked (until exiting
> ;; the minibuffer). Better exit this minibuffer right away.
> ;; Similarly with recursive-edits such as the splash screen.
> (run-with-timer 0 nil (lambda () (server-execute-continuation proc)))
> (top-level)))
>
> I could understand the rationale with the minibuffer, but I don't
> think I understand why the recursive-edit scenario needs the same
> treatment. Can you explain?
I can't remember wanting to do it for recursive-edit, so I'm pretty sure
the use of recursion-depth is just careless here and using
minibuffer-depth should work just as well.
Stefan
next prev parent reply other threads:[~2019-08-25 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 20:15 bug#37176: 27.0.50; recursive-edit interrupted by invokation of emacsclient Jean Louis
2019-08-25 7:02 ` Eli Zaretskii
2019-08-25 18:08 ` Stefan Monnier [this message]
2019-08-25 18:23 ` Eli Zaretskii
2019-08-25 18:53 ` Stefan Monnier
2019-09-07 9:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh865qfwd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=37176@debbugs.gnu.org \
--cc=bugs@gnu.support \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.