all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Subject: Re: [PATCH] Allow hiding stashes from vc-dir
Date: Fri, 18 Oct 2019 09:22:22 -0400	[thread overview]
Message-ID: <jwvh846tcj2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2a79zs5i5.fsf@gmail.com> (Robert Pluim's message of "Thu, 17 Oct 2019 18:26:10 +0200")

> +(declare-function cl-subseq "cl-extra" (seq start &optional end))

Wrong fix: if you want to use cl-lib functions, then you need to
(require 'cl-lib) outside of an eval-when-compile.  IOW you need:

    diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
    index 9715aea1fd..aa3b41454d 100644
    --- a/lisp/vc/vc-git.el
    +++ b/lisp/vc/vc-git.el
    @@ -102,8 +102,8 @@
     
     ;;; Code:
     
    +(require 'cl-lib)
     (eval-when-compile
    -  (require 'cl-lib)
       (require 'subr-x) ; for string-trim-right
       (require 'vc)
       (require 'vc-dir))


-- Stefan




  parent reply	other threads:[~2019-10-18 13:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 12:48 [PATCH] Allow hiding stashes from vc-dir Robert Pluim
2019-10-15 12:54 ` Lars Ingebrigtsen
2019-10-15 13:06 ` Eli Zaretskii
2019-10-15 14:02   ` Robert Pluim
2019-10-15 16:19     ` Eli Zaretskii
2019-10-15 18:09   ` Juri Linkov
2019-10-16  1:28     ` Lars Ingebrigtsen
2019-10-16  8:57       ` Robert Pluim
2019-10-17 16:26         ` Robert Pluim
2019-10-18  3:14           ` Lars Ingebrigtsen
2019-10-18  8:39             ` Robert Pluim
2019-10-18  9:01               ` Eli Zaretskii
2019-10-18  9:25                 ` Robert Pluim
2019-10-18  9:31                   ` Eli Zaretskii
2019-10-18 10:18                     ` Robert Pluim
2019-10-18 12:22                       ` Eli Zaretskii
2019-10-18 13:43                         ` Robert Pluim
2019-10-19  3:19                           ` Stefan Monnier
2019-10-21  9:38                             ` Robert Pluim
2019-10-19  8:18                           ` Andreas Schwab
2019-10-18 13:22           ` Stefan Monnier [this message]
2019-10-18 14:07             ` Robert Pluim
2019-10-19  3:16               ` Stefan Monnier
2019-10-19  8:15               ` Lars Ingebrigtsen
2019-10-21  9:38                 ` Robert Pluim
2019-10-15 14:40 ` Michael Albinus
2019-10-15 16:25   ` Eli Zaretskii
2019-10-16 10:18     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh846tcj2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.