From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Evgeny Zajcev <lg.zevlg@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, Eli Zaretskii <eliz@gnu.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] battery.el, upower fixes
Date: Tue, 04 Feb 2020 20:27:25 -0500 [thread overview]
Message-ID: <jwvh8054ymt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAO=W_ZrQT5Pn93cC_CEf5c41sbyACyAXHpBjiiuOodv--awcbQ@mail.gmail.com> (Evgeny Zajcev's message of "Wed, 5 Feb 2020 03:22:14 +0300")
> Hmm, maybe no reason actually. My thought was about providing some way for
> user to autodetect :battery and :line-power device in his init.el and
> explicitly write something like:
>
> (setq battery-upower-device (battery-upower-device-autodetect :battery))
>
> So he states in the config, that he has upower and want error to be rised
> if upower service is not available.
But
(setq battery-status-function #'battery-upower)
already does that in a more direct and reliable way, no?
> If `battery.el` is loaded unintentionally, then all the custom vars will
> have suitable values to have no warnings. However if user explicitly set
> `battery-upower-device` to invalid value, then warning will arise on
> battery.el load.
Exactly, and even if the user did not intend to use battery in this
session (Elisp files can be loaded "spuriously").
> Otherwise (no warning on invalid `battery-upower-device`), if upower
> service is available - `battery-status-function` will be set to
> upower, and `M-x battery RET` will produce N/A values, and there is no
> clue for the user that he just have invalid value for the
> `battery-upower-device`.
No: `M-x battery` will emit the warning.
Stefan
next prev parent reply other threads:[~2020-02-05 1:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 23:04 [PATCH] battery.el, upower fixes Evgeny Zajcev
2020-01-27 14:43 ` Stefan Monnier
2020-01-27 18:23 ` Eli Zaretskii
2020-01-29 7:05 ` Evgeny Zajcev
2020-01-29 8:37 ` Andreas Schwab
2020-01-30 10:22 ` Evgeny Zajcev
2020-02-04 19:55 ` Stefan Monnier
2020-02-04 20:16 ` Michael Albinus
2020-02-04 23:10 ` Stefan Monnier
2020-06-11 16:12 ` Basil L. Contovounesios
2020-02-05 0:22 ` Evgeny Zajcev
2020-02-05 1:27 ` Stefan Monnier [this message]
2020-02-05 2:24 ` Evgeny Zajcev
2020-02-05 3:03 ` Stefan Monnier
2020-02-06 0:55 ` Richard Stallman
2020-02-06 18:27 ` Eli Zaretskii
2020-02-06 7:48 ` Evgeny Zajcev
2020-02-06 14:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh8054ymt.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lg.zevlg@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.