From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 40332-done@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
Date: Mon, 30 Mar 2020 15:47:17 -0400 [thread overview]
Message-ID: <jwvh7y5mxxu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k131myzf.fsf@gmail.com> ("Štěpán Němec"'s message of "Mon, 30 Mar 2020 21:20:04 +0200")
Version: 28.1
> `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer
> changes caused by populating dired buffers are not noticeable in
> `after-change-functions'.
Indeed, thanks. I just installed into `master` the patch below which
should fix this problem.
Can you confirm it works for you?
Stefan
diff --git a/lisp/dired.el b/lisp/dired.el
index b66bb03471..d58c37be2f 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1208,15 +1208,11 @@ dired-readin
;; default-directory and dired-actual-switches must be buffer-local
;; and initialized by now.
- (let (dirname
- ;; This makes read-in much faster.
- ;; In particular, it prevents the font lock hook from running
- ;; until the directory is all read in.
- (inhibit-modification-hooks t))
- (if (consp dired-directory)
- (setq dirname (car dired-directory))
- (setq dirname dired-directory))
- (setq dirname (expand-file-name dirname))
+ (let ((dirname
+ (expand-file-name
+ (if (consp dired-directory)
+ (car dired-directory)
+ dired-directory))))
(save-excursion
;; This hook which may want to modify dired-actual-switches
;; based on dired-directory, e.g. with ange-ftp to a SysV host
@@ -1226,17 +1222,25 @@ dired-readin
(setq buffer-undo-list nil))
(setq-local file-name-coding-system
(or coding-system-for-read file-name-coding-system))
- (let ((inhibit-read-only t)
- ;; Don't make undo entries for readin.
- (buffer-undo-list t))
- (widen)
- (erase-buffer)
- (dired-readin-insert))
- (goto-char (point-min))
- ;; Must first make alist buffer local and set it to nil because
- ;; dired-build-subdir-alist will call dired-clear-alist first
- (setq-local dired-subdir-alist nil)
- (dired-build-subdir-alist)
+ (widen)
+ ;; We used to bind `inhibit-modification-hooks' to try and speed up
+ ;; execution, in particular, to prevent the font-lock hook from running
+ ;; until the directory is all read in.
+ ;; I strongly suspect that this was only useful in Emacs<21, because
+ ;; jit-lock made it a non-issue.
+ ;; Nevertheless, I used `combine-change-calls' which provides the
+ ;; same performance advantages, just in case.
+ (combine-change-calls (point-min) (point-max)
+ (let ((inhibit-read-only t)
+ ;; Don't make undo entries for readin.
+ (buffer-undo-list t))
+ (erase-buffer)
+ (dired-readin-insert))
+ (goto-char (point-min))
+ ;; Must first make alist buffer local and set it to nil because
+ ;; dired-build-subdir-alist will call dired-clear-alist first
+ (setq-local dired-subdir-alist nil)
+ (dired-build-subdir-alist))
(let ((attributes (file-attributes dirname)))
(if (eq (car attributes) t)
(set-visited-file-modtime (file-attribute-modification-time
next prev parent reply other threads:[~2020-03-30 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:20 bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Štěpán Němec
2020-03-30 19:47 ` Stefan Monnier [this message]
2020-03-30 20:03 ` Štěpán Němec
2020-03-31 14:40 ` Eli Zaretskii
2020-03-31 15:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh7y5mxxu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=40332-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.