all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, Noam Postavsky <npostavs@gmail.com>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3
Date: Fri, 10 Jul 2020 17:35:14 -0400	[thread overview]
Message-ID: <jwvh7uf9hs2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h7ufdtyr.fsf@gmail.com> ("João Távora"'s message of "Fri, 10 Jul 2020 20:57:00 +0100")

>> Maybe come up with a better idea, or maybe, like Stefan suggests, don't
>> make it an alias at all, just deprecate it and keep using it instead of
>> eldoc-documentation-strategy when we find it to be bound.
>
> That sort of works, but it forces extensions that do want to
> "Package-Require" eldoc to remember to unbind
> eldoc-documentation-function if they are loaded on older Emacs versions,
> which is undesirable.

Maybe use a rule like:

    (if (and (buffer-local-p 'eldoc-documentation-function)
             (not (buffer-local-p 'eldoc-documentation-functions)))
        <Use `eldoc-documentation-function`>
      <Use `eldoc-documentation-functions`>


-- Stefan




  reply	other threads:[~2020-07-10 21:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200710004934.18557.69586@vcs0.savannah.gnu.org>
     [not found] ` <20200710004936.2935520A27@vcs0.savannah.gnu.org>
2020-07-10 16:09   ` master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3 Glenn Morris
2020-07-10 17:09     ` João Távora
2020-07-10 17:36       ` Noam Postavsky
2020-07-10 17:54         ` João Távora
2020-07-10 19:57           ` João Távora
2020-07-10 21:35             ` Stefan Monnier [this message]
2020-07-10 21:58               ` João Távora
2020-07-10 22:16                 ` Stefan Monnier
2020-07-10 22:41                   ` João Távora
2020-07-10 23:44                     ` Stefan Monnier
2020-07-11  8:06                       ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh7uf9hs2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=npostavs@gmail.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.