gnus/nnimap: Search broke again?

gnus/nnimap: Search broke again?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 294 bytes --]

As of today, (emacs built yesterday) nnimap search fails with 0 hits
for imap/gmail queries like after:2021/30/01 from:rms

Did something change again?
Could we have some tests in place so the nnimap search api doesn't regress?
-- 

Thanks,

--Raman
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: gnus/nnimap: Search broke again?

[Stefan Monnier]

> As of today, (emacs built yesterday) nnimap search fails with 0 hits
> for imap/gmail queries like after:2021/30/01 from:rms
>
> Did something change again?

Probably my fault (conversion to lexical-binding).
Any chance you can provide a backtrace of something (I see you don't
actually get an error, so it might prove tricky, but maybe by setting
`debug-on-signal` [he said, unconvinced])?


        Stefan

Re: gnus/nnimap: Search broke again?

[T.V Raman]

No debug / backtrace -- just get "no results" or similar message.
Stefan Monnier writes:
 > > As of today, (emacs built yesterday) nnimap search fails with 0 hits
 > > for imap/gmail queries like after:2021/30/01 from:rms
 > >
 > > Did something change again?
 > 
 > Probably my fault (conversion to lexical-binding).
 > Any chance you can provide a backtrace of something (I see you don't
 > actually get an error, so it might prove tricky, but maybe by setting
 > `debug-on-signal` [he said, unconvinced])?
 > 
 > 
 >         Stefan

-- 
♉Id: kg:/m/0285kf1  🦮♉

--
♉Id: kg:/m/0285kf1  🦮♉

Re: gnus/nnimap: Search broke again?

[Eric Abrahamsen]

"T.V Raman" <raman@google.com> writes:

> No debug / backtrace -- just get "no results" or similar message.

Errors get swallowed by `nnselect-run'. I'd really like to get rid of
that to let errors propagate, or at least switch it to
`condition-case-unless-debug'.

Re: gnus/nnimap: Search broke again?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 734 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:


I added a couple of cl-declare special to my nnimap gmail searcher and
it's now returning results
https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L134
>> As of today, (emacs built yesterday) nnimap search fails with 0 hits
>> for imap/gmail queries like after:2021/30/01 from:rms
>>
>> Did something change again?
>
> Probably my fault (conversion to lexical-binding).
> Any chance you can provide a backtrace of something (I see you don't
> actually get an error, so it might prove tricky, but maybe by setting
> `debug-on-signal` [he said, unconvinced])?
>
>
>         Stefan
>
>

-- 

Thanks,

--Raman
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: gnus/nnimap: Search broke again?

[Stefan Monnier]

> I added a couple of cl-declare special to my nnimap gmail searcher and
> it's now returning results
> https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L134

So you're saying this change on your side fixes the problem for you?

I don't understand: this `gm-nnir` is not part of the code I converted
to lexical-binding.  The change your URL points seems to fix a problem
in your code, indeed, but I can't see why this problem would have
appeared at the same time as my changes.

I do notice something odd also in that change of yours: why do you
`cl-declare` as a special var `gnus-group-group-name` which is
a function (and which you indeed don't use as a variable either)?


        Stefan

Re: gnus/nnimap: Search broke again?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1092 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

I might well have been confused, not sure. Thanks for pointing out that
I declared a function name as a special -- that must have been  me
getting very confused.

For whatever reason though the bug has now disappeared.>> I added a couple of cl-declare special to my nnimap gmail searcher and
>> it's now returning results
>> https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L134
>
> So you're saying this change on your side fixes the problem for you?
>
> I don't understand: this `gm-nnir` is not part of the code I converted
> to lexical-binding.  The change your URL points seems to fix a problem
> in your code, indeed, but I can't see why this problem would have
> appeared at the same time as my changes.
>
> I do notice something odd also in that change of yours: why do you
> `cl-declare` as a special var `gnus-group-group-name` which is
> a function (and which you indeed don't use as a variable either)?
>
>
>         Stefan
>

-- 

Thanks,

--Raman
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: gnus/nnimap: Search broke again?

[Stefan Monnier]

> I might well have been confused, not sure. Thanks for pointing out that
> I declared a function name as a special -- that must have been  me
> getting very confused.
>
> For whatever reason though the bug has now disappeared.

Good, thanks.  Let's hope it's gone for good,


        Stefan