From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 47813@debbugs.gnu.org
Subject: bug#47813: 28.0.50; Confusing new calling convention for define-minor-mode
Date: Fri, 16 Apr 2021 20:44:24 -0400 [thread overview]
Message-ID: <jwvh7k5d9p1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <877dl17pmv.fsf@web.de> (Michael Heerdegen's message of "Sat, 17 Apr 2021 01:53:28 +0200")
>> Hmm... the warning don't exactly say to delete those three elements, so
>> I think it would help to understand how you got from "saw the warning"
>> to "deleted all those nil's": that's the probably where we need to
>> improve the doc.
>
> What is currently the correct syntax if you can't provide any keywords
> because your definition only has a body to specify?
The three args of the old convention correspond to (by order of
appearance): `:init-value`, `lighter`, `:keymap`.
So in the patch I installed into `master` I used `:lighter nil` to
replace three `nil`s (since `:init-value` and `:keymap` should only be
used in exceptional circumstances, IMO).
> So that was what Emacs presented to me: a calling convention that told
> to use (mode doc &rest body) which I did, and OTOH a non-decreasing
> number of warnings to use keywords please , but I have none to specify,
> so ... what?
Yes, I understand the problem, but I'm not sure how best to address it.
Do you have some suggestion for what could have helped you?
Stefan
next prev parent reply other threads:[~2021-04-17 0:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 1:51 bug#47813: 28.0.50; Confusing new calling convention for define-minor-mode Michael Heerdegen
2021-04-16 3:23 ` Stefan Monnier
2021-04-16 3:27 ` Stefan Monnier
2021-04-16 4:26 ` Michael Heerdegen
2021-04-16 12:43 ` Stefan Monnier
2021-04-16 23:53 ` Michael Heerdegen
2021-04-17 0:44 ` Stefan Monnier [this message]
2021-04-17 2:28 ` Michael Heerdegen
2021-04-17 3:42 ` Stefan Monnier
2021-04-17 11:49 ` Lars Ingebrigtsen
2021-04-17 13:57 ` Stefan Monnier
2021-04-17 23:21 ` Michael Heerdegen
2021-04-18 3:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh7k5d9p1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=47813@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.