From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 17a950c: Fix comment end delimiter fontification in OPascal mode Date: Wed, 12 May 2021 10:07:25 -0400 Message-ID: References: <20210511135237.14950.6701@vcs0.savannah.gnu.org> <20210511135238.D80A321128@vcs0.savannah.gnu.org> <87r1idkz83.fsf@gnus.org> <87im3ojbw2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 12 16:09:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgpY6-0003tU-Ni for ged-emacs-devel@m.gmane-mx.org; Wed, 12 May 2021 16:09:18 +0200 Original-Received: from localhost ([::1]:40720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgpY5-0004FH-Kq for ged-emacs-devel@m.gmane-mx.org; Wed, 12 May 2021 10:09:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgpWN-0002ff-6K for emacs-devel@gnu.org; Wed, 12 May 2021 10:07:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgpWL-0007Rs-5P for emacs-devel@gnu.org; Wed, 12 May 2021 10:07:30 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1F797440504; Wed, 12 May 2021 10:07:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C860D44016E; Wed, 12 May 2021 10:07:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620828446; bh=Q0p0vI29gaqaJFRSHc4x+6SRRTz8bCcbL9wasGcUwng=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P3lNKp5zelZjIeDhgJCFDwVParzNwRp0qWIpe/VwE+8RlGeyXtsk6HAY5YK3uXEZd pApS29itH+OuGbMGWZTKSSzQG2WA4aRJTt6BCHHrvDt8Cxp0fVgrOl1DD7BcSRzESq z14aoGQza8bTiAhplrbnHPPINDOfTFfCYqW/ZE05EGh7+gZ8PNS2Cnc1qxtdamjuw9 WFJeh8x83oqaWGfr7VnB0bVECNOzzGNHLXH5edza/0yub3kNX3aydxoEpUAqNfQODK k9wkqpPsDN7ooBUFPq3INm+aUGKp28bc3Cgt8zV3zVUqB6i2uBeqcQ9rsXzdJXpIM+ ZJFVLZAqhl+Zg== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9194212067B; Wed, 12 May 2021 10:07:26 -0400 (EDT) In-Reply-To: <87im3ojbw2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 12 May 2021 15:54:21 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269206 Archived-At: Lars Ingebrigtsen [2021-05-12 15:54:21] wrote: > Stefan Monnier writes: >> I suspect you need to set `font-lock-comment-end-skip`, tho I think the >> real problem is that `font-lock.el` should use `comment-end-skip` rather >> than `comment-end` as a fallback for `font-lock-comment-end-skip`. >> So I pushed the patch below. > > Great! > > Should something similar be done to pascal.el, which has: > > (setq-local comment-start "{") > (setq-local comment-start-skip "(\\*+ *\\|{ *") > (setq-local comment-end "}") It should probably set `comment-end-skip`, yes. Stefan