From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2d15641: * lisp/mouse.el (context-menu-map): Fix when menu is a command (bug#50851) Date: Tue, 28 Sep 2021 15:29:51 -0400 Message-ID: References: <20210928190055.3772.68409@vcs0.savannah.gnu.org> <20210928190056.D8A02207F5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 28 21:32:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVIpm-000AKg-F4 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Sep 2021 21:32:10 +0200 Original-Received: from localhost ([::1]:47072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVIpk-0003rM-P4 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Sep 2021 15:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVIoE-0001zc-Fm for emacs-devel@gnu.org; Tue, 28 Sep 2021 15:30:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVIoC-0000XV-VX for emacs-devel@gnu.org; Tue, 28 Sep 2021 15:30:34 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EE598441649; Tue, 28 Sep 2021 15:30:31 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BA46B44163E; Tue, 28 Sep 2021 15:30:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1632857430; bh=WzE8qyEqbL6A+ERhGynskFXWrruRQsMQ+GjA09ab3o8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jtbmjlDtnjH9hqkmqDKyJYNlHT1H2VrYIJrueTwA9ABQmCe6Rq9kY1aTnbvXpdmrN bK0I4qf541OqqphzES46cWRKhPjWI2iRGd+ugeGnY687GUx9R5SR/Qe8laCFfVmIiF TodIzx7xOhO+InrLYpDfX52QXQTaKln4hPL3fPhY/FJFLZigU3OCDxMFKJ3nH7RrYy pv3E9Q/xjPJFae14FFsy7osHO+ae3CrJlAjBzIhlcDrRTgRPqfRm+RdjRpAUGDWpIM 6NWGzIWLBiDJAaqkiaBc+FPNkRWWff/zwrB/P70ceRM6hqjwYSJn0JPwMmVpcpzI38 OvORInwaC9vNA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7AFCD12017E; Tue, 28 Sep 2021 15:30:30 -0400 (EDT) In-Reply-To: <20210928190056.D8A02207F5@vcs0.savannah.gnu.org> (Juri Linkov's message of "Tue, 28 Sep 2021 15:00:56 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275735 Archived-At: > - (defn (key-binding key t))) > + (defn (save-excursion (mouse-set-point event) (key-binding key t)))) Could you add a comment explaining why it is safe to do that even though it can mess with the selected window(&frame)? [ IIRC you used a similar chunk of code recently in that vicinity, so I guess my question applies to that as well. ] Stefan