all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com,  emacs-devel@gnu.org
Subject: Re: master 501e2096d6: Fix some issues with a recent change
Date: Sun, 26 Dec 2021 23:27:09 -0500	[thread overview]
Message-ID: <jwvh7aud6px.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <837dbqohgz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Dec 2021 05:27:08 +0200")

> Once again, personal workflows should not affect our coding
> conventions.

AFAIK the conventions are designed to help the various workflows out
there.  Some parts of the convention will only be useful for some of
those workflows, of course.  We do have a convention about the first
line being a kind of summary, even though you seem not to care about
that convention.

Why do we bother with such a first-line-convention if it doesn't even
give any indication whatsoever about which part of the codebase
is modified?

A summary should say something non-trivial about the change.
"Fix some issues with a recent change" does say something, indeed.
AFAICT it gives the following info:
- it's related to something "recent".
- it fixes something rather than adding a new feature.
That's still very vague in my book.

I don't care if the first line lists specific files (the space
constraints are obviously much too severe to impose such a requirement),
but it should give some vague idea about which part of the codebase
is affected.


        Stefan




  reply	other threads:[~2021-12-27  4:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164051393145.21885.8315099612759503047@vcs2.savannah.gnu.org>
     [not found] ` <20211226101851.B61E5C04DCC@vcs2.savannah.gnu.org>
2021-12-26 17:04   ` master 501e2096d6: Fix some issues with a recent change Stefan Monnier
2021-12-26 18:18     ` Eli Zaretskii
2021-12-26 21:12       ` Stefan Monnier
2021-12-27  0:56         ` Po Lu
2021-12-27  4:22           ` Stefan Monnier
2021-12-27  5:01             ` Po Lu
2021-12-27  6:14               ` Stefan Monnier
2021-12-27  6:19                 ` Po Lu
2021-12-27 12:07                   ` Óscar Fuentes
2021-12-27 20:18                   ` Stefan Monnier
2021-12-27 23:19                     ` Stefan Kangas
2021-12-28  3:25                       ` Eli Zaretskii
2021-12-28  3:48                         ` Stefan Kangas
2021-12-27 16:20                 ` [External] : " Drew Adams
2021-12-27  3:27         ` Eli Zaretskii
2021-12-27  4:27           ` Stefan Monnier [this message]
2021-12-27 14:31             ` Eli Zaretskii
2021-12-27 14:40           ` Dmitry Gutov
2021-12-27 12:08     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh7aud6px.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.