From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add history to Custom commands Date: Fri, 21 Jan 2022 12:57:31 -0500 Message-ID: References: <87y23ajafr.fsf@ya.ru> <87mtjpv2bp.fsf@gnus.org> <87pmoljsmx.fsf@ya.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Ivan Sokolov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 21 19:04:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAyGu-000050-Sx for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 19:04:25 +0100 Original-Received: from localhost ([::1]:50252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAyGs-0005aO-Rv for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 13:04:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAyAL-0007Wd-BE for emacs-devel@gnu.org; Fri, 21 Jan 2022 12:57:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAyAJ-0003L2-Ka for emacs-devel@gnu.org; Fri, 21 Jan 2022 12:57:36 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7069F80539; Fri, 21 Jan 2022 12:57:34 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DBE4D80508; Fri, 21 Jan 2022 12:57:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642787852; bh=+8xZydzruaZcbdHW7VX/USJ72etjR59G4fqyRfI9hpo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Bt3isRA6gN0aD/DAzbW6EPD3sgdrXfgZXIoR8HEW1RvFdxYu9VvpZ5KTDJFsSJsym Q2f84VoSUj6b9k5odtgWvf/3rtdOx7uNmDeFxVN83qM4klsx4mo2dsRPrU0YFwuzHR ZozVMUVYdcDe2Kaxz5bLyu3HN31PQkXkS3kDRC5qfVMoCRbAlLBJRh/uUXV9+ZZuK0 HhWbfxPILbDcm+geC9CYYq+ZzRPanb+8qleBssx8VsJyZN1/h+KMZf5ACQzJrzS+lQ t7qZv3amsSxNNzs842sX4UaqT8lvMUIMVBKeXqAxKksc6iy4iWiueCTGi7QMBchP5u XzgUqmD2f1gug== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B4E0F1202C1; Fri, 21 Jan 2022 12:57:32 -0500 (EST) In-Reply-To: <87pmoljsmx.fsf@ya.ru> (Ivan Sokolov's message of "Fri, 21 Jan 2022 13:21:58 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285150 Archived-At: > Maybe I was too hasty with this patch. I was using customize-variable > instead of revert-buffer, which is unavailable for Custom buffers, and [...] Maybe a more direct fix is to improve Custom so it does provide a proper `revert-buffer-function`? Stefan