From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 55684@debbugs.gnu.org
Cc: Alan Mackenzie <acm@muc.de>
Subject: bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames
Date: Fri, 27 May 2022 16:09:13 -0400 [thread overview]
Message-ID: <jwvh75aivpy.fsf@iro.umontreal.ca> (raw)
Package: Emacs
Version: 29.0.50
src/emacs -Q --eval '(setq default-frame-alist `((minibuffer . nil)))'
Stays "frozen" because of a wrong-type-argument error in
`Fset_frame_selected_window` on `CHECK_LIVE_WINDOW (window);`.
The patch below seems to "fix" it, but I must admit that I don't really
understand this code (see for example the FIXME comment in the patch).
Does someone know what is the user-level behavior we're trying to
obtain here?
It seems that this comes from Alan's commit dfa3e6f424b20fe27d904.
Stefan
diff --git a/src/frame.c b/src/frame.c
index 252dc591bfa..dc55004b193 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -1576,8 +1576,14 @@ do_switch_frame (Lisp_Object frame, int track, int for_deletion, Lisp_Object nor
to a different window, the most recently used one, unless there is a
valid active minibuffer in the mini-window. */
if (EQ (f->selected_window, f->minibuffer_window)
+ /* FIXME: Can this test ever fail? I.e. can 'minibuffer_window'
+ ever contain a non-mini-buffer (and if so, should we care here)? */
&& NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt)))
- Fset_frame_selected_window (frame, call1 (Qget_mru_window, frame), Qnil);
+ {
+ Lisp_Object w = call1 (Qget_mru_window, frame);
+ if (!NILP (w)) /* Can be nil in minibuffer-only frames. */
+ Fset_frame_selected_window (frame, w, Qnil);
+ }
Fselect_window (f->selected_window, norecord);
next reply other threads:[~2022-05-27 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 20:09 Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-28 5:56 ` bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames Eli Zaretskii
2022-05-28 10:51 ` Alan Mackenzie
2022-05-28 10:57 ` Eli Zaretskii
2022-05-28 13:09 ` Alan Mackenzie
2022-05-28 13:18 ` Eli Zaretskii
2022-05-28 10:48 ` Alan Mackenzie
2022-05-28 14:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh75aivpy.fsf@iro.umontreal.ca \
--to=bug-gnu-emacs@gnu.org \
--cc=55684@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.