From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Date: Wed, 24 Aug 2022 22:06:53 -0400 Message-ID: References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 25 04:08:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR2I0-0000jm-AE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 04:08:12 +0200 Original-Received: from localhost ([::1]:57482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oR2Hy-0001rx-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 22:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR2Hr-0001rp-3J for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 22:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oR2Hq-0004jX-RP for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 22:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oR2Hq-0008Of-Fd for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 22:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 02:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs Original-Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166139323132218 (code B ref 50245); Thu, 25 Aug 2022 02:08:02 +0000 Original-Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 02:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:48484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oR2Gx-0008NW-T0 for submit@debbugs.gnu.org; Wed, 24 Aug 2022 22:07:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oR2Gs-0008Mx-6Z for 50245@debbugs.gnu.org; Wed, 24 Aug 2022 22:07:06 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4FBB54417DA; Wed, 24 Aug 2022 22:06:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1E2A54417F2; Wed, 24 Aug 2022 22:06:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661393215; bh=SHRvMuRYmQHkwOjoc3AsGBOlbvuvjLJrw44yWRxXaNM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VTZFpR4NRJLIVdACmNqrimBGPFM6DbjwLhZJU7ek3lPVKucULa4Sfzgj2UT3F8VEf bOVkcT9bhUriWNL5ZeGkTIkA32MlGXA/WBaIfTQIhfmwW8vF5jIW0gGI1Sz0UXK5ZN Tm9zsf6TPVjRPoOfActAeUOY27JfaVtgCDbdRtjeYNQvBRIFP71idOACrX8j3IvWRN AZZtux4A6av2sDwb1wH4O26iG6Zp5fmB4e7i5eBy4LsxX+NigsQQICQ6CIqOeoX9aG NSahkR8dEsXElNt6yWxtlDUD+TpBhv6IU1ffN9T3MGXF+Z4rvUz652nla1IIVBImr4 p9XAVEMv1DFYw== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7233120306; Wed, 24 Aug 2022 22:06:54 -0400 (EDT) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Thu, 25 Aug 2022 00:32:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240677 Archived-At: > Here's a new version of the patch, which addresses Stefan's feedback. Thanks. One question, tho: > @@ -1643,7 +1643,10 @@ elisp--eval-defun > ;; FIXME: the print-length/level bindings should only be applied while > ;; printing, not while evaluating. > (defvar elisp--eval-defun-result) > + ;; FIXME: This Edebug dependency is undesirable. See bug#50245 > + (defvar edebug-all-defs) > (let ((debug-on-error eval-expression-debug-on-error) > + (edebugging edebug-all-defs) > elisp--eval-defun-result) > (save-excursion > ;; Arrange for eval-region to "read" the (possibly) altered form. What makes us think that `edebug-all-defs` will always be defined when we get here? Doesn't this code signal an error if called before edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by a plain `C-M-x`)? Stefan