From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 12:53:55 -0400 Message-ID: References: <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> <83pm6b5t1i.fsf@gnu.org> <878rczo28v.fsf@posteo.net> <83o7lv5sjc.fsf@gnu.org> <874jnno1bi.fsf@posteo.net> <83mt1f5rab.fsf@gnu.org> <87zg5fmkgk.fsf@posteo.net> <83a5xf5k65.fsf@gnu.org> <87cz2bxkz5.fsf@posteo.net> <834jnn5gxh.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27267"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , 63757@debbugs.gnu.org, artscan@list.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 18:55:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5r0k-0006se-CC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 18:55:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5r0S-0005Rl-3o; Sun, 04 Jun 2023 12:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5r0R-0005Rd-69 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5r0Q-00064f-TD for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5r0Q-0007iZ-Hg for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168589764829601 (code B ref 63757); Sun, 04 Jun 2023 16:55:02 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 16:54:08 +0000 Original-Received: from localhost ([127.0.0.1]:47033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5qzY-0007hN-Bg for submit@debbugs.gnu.org; Sun, 04 Jun 2023 12:54:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5qzX-0007h5-Js for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 12:54:07 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4A9584417E2; Sun, 4 Jun 2023 12:54:02 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CBFD44411E8; Sun, 4 Jun 2023 12:53:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1685897636; bh=ddYqqhZx8X3e2o+WOZtxumuU968Kz587vo5oOXG61Ks=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CkG8w0fGH5LNqlfPq8XRT2Xc9IOfJTTR6LzbuFhp8kinPkdGtLtzcpmK3Avp5IETe fM/IDvmb6qqusdMQgLx8Hk0qfCWKQhxTnZJJNtOTq/inBVj3h/+Fs7wboHVNCixt+6 PQC5WTek+13f1BgWg0lreOESj6Ysy3DPbThmdx3xzZqV7BS+gEKpVqsHk6RUVoO+Uq aMwgolskJDqynu7XO79sB+1YtUkBrRUupGLOzP2rl9PRwYQu4n8v8c1gIbO9EC9YSc JCyWHytOpCRNYDF2XSY2abl/wle+lFzv4JRPFNrwN2KCFwRCtYs5wV+2YcBBcgfXYm Bvb1RuS1HGndg== Original-Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 89002120473; Sun, 4 Jun 2023 12:53:56 -0400 (EDT) In-Reply-To: <834jnn5gxh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Jun 2023 19:30:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262976 Archived-At: > So what exactly was the change installed back in Aug 2022 supposed to > improve? I believe its intention was only to give preference to the VC packages (I still don't know why it moved the "prefer built-in packages" part (and then changed it to test `package-disabled-p`); I presume it was an accident). So my patch *may* be a regression for users of `package-vc`, but since it's a new feature in Emacs-29, I think it's perfectly acceptable. Especially because the sort it implemented is wrong (because the sort predicate fails to define a partial order, so the output will depend on arbitrary details of how `sort` happens to pass elements to the predicate), so it's not at all clear that it does what it intends to do anyway. Furthermore I believe that it is mostly redundant: VC packages should almost always already be sorted first by virtue of the version being almost always higher than non-VC packages. Stefan