all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: m43cap@yandex.com, Lars Ingebrigtsen <larsi@gnus.org>,
	64927@debbugs.gnu.org
Subject: bug#64927: 30.0.50; kill-ring with no X
Date: Thu, 03 Aug 2023 11:11:24 -0400	[thread overview]
Message-ID: <jwvh6pg89p4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <838rasxxlw.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Aug 2023 12:51:23 +0300")

> This also affects Emacs 29, and is a regression from Emacs 28, which
> is related to the use of the new key-* functions.  Specifically, the
> error is signaled by the call to key-valid-p issued by
> possibly_translate_key_sequence, which is a subroutine of lookup-key.
> The argument KEY of possibly_translate_key_sequence in this case is a
> vector whose only element is a string with text properties:
>
>   [#("create a file" 0 13 (face font-lock-comment-face fontified t))]
>
> key-valid-p doesn't support such strings, it expects strings that
> describe key sequences.
>
> Significantly, possibly_translate_key_sequence calls key-parse after
> it calls key-valid-p, and key-parse copes with this string quite well.

No, `key-parse` doesn't handle this correctly either.

The ["create a file"] above is an "internal" key-sequence of length
1 that happens to use a string as the sole key.

`possibly_translate_key_sequence` instead is trying to handle the new
"external" key-sequence format [<KBDSTRING>] where <KBDSTRING> is using
the `kbd` syntax, i.e. the string is not itself a key but represents
a key-sequence.

IOW, this is a fundamental incompatibility introduced by the support for
this new [<KBDSTRING>] format in `define-key`: keys cannot be arbitrary
objects any more (among other things they can't be strings any more).


        Stefan






  reply	other threads:[~2023-08-03 15:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29  9:47 bug#64927: 30.0.50; kill-ring with no X Colin Baxter
2023-07-29 11:25 ` Colin Baxter
2023-08-03  9:51   ` Eli Zaretskii
2023-08-03 15:11     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-03 16:00       ` Eli Zaretskii
2023-08-03 16:06         ` Eli Zaretskii
2023-08-03 16:30         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:26           ` Eli Zaretskii
2023-08-03 21:13             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04  6:14               ` Colin Baxter
2023-08-04  6:38                 ` Eli Zaretskii
2023-08-03 19:55     ` Colin Baxter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh6pg89p4.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=64927@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=m43cap@yandex.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.