From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) Date: Fri, 03 May 2024 13:27:45 -0400 Message-ID: References: <86ttjr2pzw.fsf@gnu.org> <86edau3gyy.fsf@gnu.org> <8634ra36ny.fsf@gnu.org> <861q6ou2cs.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rcopley@gmail.com, 70541@debbugs.gnu.org, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 03 19:30:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2wkA-0007p0-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 May 2024 19:30:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2whX-0006sW-9M; Fri, 03 May 2024 13:28:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2whV-0006rb-GP for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 13:28:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2whV-0007NN-57 for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 13:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2whr-0004GJ-KU for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 13:28:23 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 17:28:23 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70541 X-GNU-PR-Package: emacs Original-Received: via spool by 70541-submit@debbugs.gnu.org id=B70541.171475729916296 (code B ref 70541); Fri, 03 May 2024 17:28:23 +0000 Original-Received: (at 70541) by debbugs.gnu.org; 3 May 2024 17:28:19 +0000 Original-Received: from localhost ([127.0.0.1]:47508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2whm-0004Ef-NM for submit@debbugs.gnu.org; Fri, 03 May 2024 13:28:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2whk-0004Bk-Pn for 70541@debbugs.gnu.org; Fri, 03 May 2024 13:28:17 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 49292806AA; Fri, 3 May 2024 13:27:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1714757266; bh=3fb3V0KlYju2gbcd1O2B60Mhh1/VXv5+enn2tbWP/GY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A0+YLBBHHcDxq8etSePVbu2tfSUnAnxtYtDtQkxv/AsizZJGi7AYTE9nA76VmMWgn Swa2+LqzxxyhZ7ERYvlxQLB4jeauCnjxMIOOH/aftOeuVa7N16Conh0W+PO/GwxUl3 8HtsgGHxwqSWAD/3nghxML01+yQfG9dTKMtOmqBBvVzQ0h7UC/eFP1jUziE4uUi+iB 6OB4Cz7+IZrXHlo+fHPfpzgrC2XWVB9dr408BZORPi9GJZtjVmXpEx/+ZRvtYYpL91 FPErdIVdjJSFOcLESBwP2Q/SEJY21eDah/s8YesLfmwLy/U0AM+ab4x9bSUDfZbwP1 o9EuJB5SP0rOA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 20DF280136; Fri, 3 May 2024 13:27:46 -0400 (EDT) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EECC6120211; Fri, 3 May 2024 13:27:45 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Mon, 29 Apr 2024 16:27:42 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284390 Archived-At: > I guess we could add a function `track-change-inconsistent-state-p` > which Eglot could consult before calling `track-changes-fetch` and if > that returns non-nil, Eglot could reschedule the update to "later". I just pushed a patch to `master` which does that. Richard, can you confirm it fixes the problem on your end? The problem of Quail binding `inhibit-modification-hooks` remains, of course. We should fix it because it can affect many more things: all the code run in the middle of a Quail input sequence (e.g. timers and process filters) are effected, not just because they may see an "inconsistent" buffer state but because the changes they make to buffers will themselves be affected by the `inhibit-modification-hooks` binding. Stefan