all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"
Date: Mon, 30 Dec 2024 19:08:05 -0500	[thread overview]
Message-ID: <jwvh66kn2bv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20241231000431.DB05AE2FE49@vcs3.savannah.gnu.org> (ELPA Syncer's message of "Mon, 30 Dec 2024 19:04:31 -0500 (EST)")

> branch: elpa/scala-mode
> commit c2a4f58643eb505f38c8e341a29400e79f47f442
> Author: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> Commit: Konstantin Kharlamov <Hi-Angel@yandex.ru>
>
>     Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"
[...]
> @@ -583,7 +583,7 @@ keyword, or nil if not."
>  ;;; Block
>  ;;;
>  
> -(defun scala-indent:goto-block-anchor ()
> +(defun scala-indent:goto-block-anchor (&optional point)
>    "Moves back to the point whose column will be used as the
>  anchor for calculating block indent for current point (or point
>  `point'). Returns point or (point-min) if not inside a block."

If the argument is unused, then you should rename it to `_point` which
(by convention) says explicitly that this arg is not used.


        Stefan




       reply	other threads:[~2024-12-31  0:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173560347147.2633946.7946382225330277437@vcs3.savannah.gnu.org>
     [not found] ` <20241231000431.DB05AE2FE49@vcs3.savannah.gnu.org>
2024-12-31  0:08   ` Stefan Monnier [this message]
2025-01-02 18:11     ` [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`" Konstantin Kharlamov
2025-01-02 19:12       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh66kn2bv.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=Hi-Angel@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.