From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch: fix wrong-type-argument error in vc-registered Date: Tue, 12 Oct 2004 12:14:39 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <87pt3ohu06.wl%yoichi@geiin.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1097597702 26964 80.91.229.6 (12 Oct 2004 16:15:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 12 Oct 2004 16:15:02 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 12 18:14:52 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CHPIZ-0001F3-00 for ; Tue, 12 Oct 2004 18:14:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CHPPZ-0006fX-9k for ged-emacs-devel@m.gmane.org; Tue, 12 Oct 2004 12:22:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CHPPT-0006fK-EE for emacs-devel@gnu.org; Tue, 12 Oct 2004 12:21:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CHPPS-0006ex-Va for emacs-devel@gnu.org; Tue, 12 Oct 2004 12:21:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CHPPS-0006eu-J9 for emacs-devel@gnu.org; Tue, 12 Oct 2004 12:21:58 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CHPIQ-0000T3-Ri for emacs-devel@gnu.org; Tue, 12 Oct 2004 12:14:43 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 8B16B8282A7; Tue, 12 Oct 2004 12:14:42 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 2950D4AC5A3; Tue, 12 Oct 2004 12:14:40 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id C76A98CA23; Tue, 12 Oct 2004 12:14:39 -0400 (EDT) Original-To: Yoichi NAKAYAMA In-Reply-To: <87pt3ohu06.wl%yoichi@geiin.org> (Yoichi NAKAYAMA's message of "Tue, 12 Oct 2004 23:48:57 +0900") User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=0, requis 5) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28314 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28314 > 2004-09-12 Stefan Monnier > * vc-hooks.el (vc-ignore-dir-regexp): New var. > overlooked that (file-name-directory file) may return nil. > Following is the patch against it. Hmm... your patch looks fine, except that I don't understand why it's needed: I thought vc-registered is only ever called with an absolute file name, and (file-name-directory file) never returns nil if file is an absolute file name. In which cases does it return nil on an absolute file name, or in which cases is vc-registered called with a non-absolute file name? Stefan