From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fwd: vc-svn.el and "the underscore hack" Date: Wed, 01 Nov 2006 11:29:23 -0500 Message-ID: References: <17735.25691.286000.488074@gargle.gargle.HOWL> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1162398682 19319 80.91.229.2 (1 Nov 2006 16:31:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Nov 2006 16:31:22 +0000 (UTC) Cc: rms@gnu.org, spiegel@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 01 17:31:17 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GfIzg-0001lt-HJ for ged-emacs-devel@m.gmane.org; Wed, 01 Nov 2006 17:31:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GfIzg-0001E3-0S for ged-emacs-devel@m.gmane.org; Wed, 01 Nov 2006 11:31:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GfIym-0000Gl-PV for emacs-devel@gnu.org; Wed, 01 Nov 2006 11:30:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GfIye-0008SO-1j for emacs-devel@gnu.org; Wed, 01 Nov 2006 11:30:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GfIyd-0008S2-NQ for emacs-devel@gnu.org; Wed, 01 Nov 2006 11:30:07 -0500 Original-Received: from [209.226.175.34] (helo=tomts13-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GfIxy-00021v-Cd; Wed, 01 Nov 2006 11:29:26 -0500 Original-Received: from pastel.home ([70.53.195.103]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20061101162924.NECU29052.tomts13-srv.bellnexxia.net@pastel.home>; Wed, 1 Nov 2006 11:29:24 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DD5C17F8A; Wed, 1 Nov 2006 11:29:23 -0500 (EST) Original-To: AriT93 In-Reply-To: <17735.25691.286000.488074@gargle.gargle.HOWL> (AriT's message of "Tue\, 31 Oct 2006 08\:57\:31 -0600") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.90 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61555 Archived-At: >> Would someone like to work on this? There is a proposed patch >> in the second message. > I have tested this now on both windows and Gentoo GNU/Linux and have > not encountered any issues. However I have recently been using > psvn.el from http://www.xsteve.at/prg/emacs/psvn.el and in that file > they are using a defun to set the svn admin directory name. The > function checks for environment to determine which directory name to > use (.svn or _svn). That looks like a better way to do it than what I > did in my patch. I will attempt to make a similar change to vc-svn.el > and submit a patch if there are no objections. > I do have one question, is this list the correct place to post that > patch or should it be sent to the subversion people. vc-svn.el > indicates that this file is maintained here. I just wanted to make > sure I send it to the right place. As mentioned elsewhere the ".foo -> _foo" transformation is not specific to Subversion and/or Emacs, so I think we should not handle it specially in vc-svn.el but instead in a more generic way, maybe directly in the C code or at least by providing a function that handles it. Stefan