From: Stefan Monnier <monnier@iro.umontreal.ca>
To: tromey@redhat.com
Cc: Emacs Hackers <emacs-devel@gnu.org>
Subject: Re: Patch to make VC annotate async
Date: Sun, 24 Jun 2007 15:33:51 -0400 [thread overview]
Message-ID: <jwvfy4hw3s4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3d4zm3wwk.fsf@fleche.redhat.com> (Tom Tromey's message of "Sat\, 23 Jun 2007 20\:32\:11 -0600")
> This patch changes the VC annotate command to allow back ends to run
> annotation in the background. It also changes the CVS back end to
> do this.
I've been using a local patch to do the same thing for a long time now.
The main problem has been that the UI is somewhat incompatible with an async
behavior: the coloring of lines may depend on the overall youngest and
oldest lines, so the color of even the first line may depend on the content
of the last line.
IIRC that was the main reason not to accept my changes at first.
But IIRC I've fixed this since so that the colors are updated as the content
comes along. I'll try and extract a new patch for it.
> * vc.el (vc-annotate-display-select): Don't pop to buffer if one
> is specified.
> (vc-annotate): Run vc-annotate-display-select via vc-exec-after.
Oh, so you don't even add the coloring until after the whole data
was received. Hmmm...
> * vc-cvs.el (vc-cvs-annotate-output): New variable.
> (vc-cvs-annotate-process-filter): New function.
> (vc-cvs-annotate-command): Run command async. Use
> vc-cvs-annotate-process-filter.
I don't understand the prupose of vc-cvs-annotate-process-filter. In my
implementation I haven't needed any change to vc-cvs.el other than passing
the `async' flag to vc-do-command.
Stefan
next prev parent reply other threads:[~2007-06-24 19:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 2:32 Patch to make VC annotate async Tom Tromey
2007-06-24 17:35 ` Richard Stallman
2007-06-24 18:05 ` Tom Tromey
2007-06-24 23:47 ` Richard Stallman
2007-06-24 19:33 ` Stefan Monnier [this message]
2007-06-24 21:32 ` Tom Tromey
2007-06-25 1:34 ` Stefan Monnier
2007-06-25 15:24 ` Tom Tromey
2007-06-25 16:54 ` Stefan Monnier
2007-06-25 17:53 ` Tom Tromey
2007-06-26 17:48 ` Stefan Monnier
2007-07-07 21:06 ` Stefan Monnier
2007-07-09 15:12 ` Tom Tromey
2007-07-09 19:09 ` David Kastrup
2007-07-11 16:02 ` Tom Tromey
2007-07-12 3:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfy4hw3s4.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.