From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] vc-annotate-toggle-annotation-visibility, almost Date: Sat, 03 Nov 2007 23:13:29 -0400 Message-ID: References: <87zlxu4x3o.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194146025 16190 80.91.229.12 (4 Nov 2007 03:13:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Nov 2007 03:13:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 04 04:13:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IoVvn-0006UI-SC for ged-emacs-devel@m.gmane.org; Sun, 04 Nov 2007 04:13:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IoVvd-0000kt-Bz for ged-emacs-devel@m.gmane.org; Sat, 03 Nov 2007 23:13:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IoVvZ-0000dv-9H for emacs-devel@gnu.org; Sat, 03 Nov 2007 23:13:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IoVvX-0000Zi-R4 for emacs-devel@gnu.org; Sat, 03 Nov 2007 23:13:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IoVvX-0000Z3-Ck for emacs-devel@gnu.org; Sat, 03 Nov 2007 23:13:31 -0400 Original-Received: from tomts10.bellnexxia.net ([209.226.175.54] helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IoVvX-0007Jc-6X for emacs-devel@gnu.org; Sat, 03 Nov 2007 23:13:31 -0400 Original-Received: from ceviche.home ([74.12.208.82]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071104031330.KFFL1733.tomts10-srv.bellnexxia.net@ceviche.home> for ; Sat, 3 Nov 2007 23:13:30 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B7D9AB40D7; Sat, 3 Nov 2007 23:13:29 -0400 (EDT) In-Reply-To: <87zlxu4x3o.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Sun, 04 Nov 2007 02:29:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82484 Archived-At: > "almost" because i don't see any change w/ `redisplay' > in `vc-annotate-toggle-annotation-visibility'; use of > `force-mode-line-update' is suboptimal. still investigating. Use of force-mode-line-update doesn't seem particularly bad to me (assuming it works). > You can use the mode-specific menu to alter the time-span of the used > colors. See variable `vc-annotate-menu-elements' for customizing the > menu items." > + (setq buffer-invisibility-spec nil) > (set (make-local-variable 'truncate-lines) t) > (set (make-local-variable 'font-lock-defaults) > '(vc-annotate-font-lock-keywords t)) > (view-mode 1)) Why? > + (when (get-text-property (point) 'invisible) > + (goto-char (next-single-property-change (point) 'invisible))) What is this for? We could additionally put commands to print the (invisible) annotation in the echo-area, and also add a `help-echo' property to the whole buffer so as to get tooltips that display the (invisible) annotation. Stefan