From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-find-root and nonexistent drives Date: Sat, 16 Feb 2008 15:16:07 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203192989 4808 80.91.229.12 (16 Feb 2008 20:16:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 20:16:29 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 16 21:16:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQTSt-0000Fh-R0 for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 21:16:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQTSP-00020l-H8 for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 15:16:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQTSL-0001zi-C5 for emacs-devel@gnu.org; Sat, 16 Feb 2008 15:16:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQTSJ-0001y4-Sw for emacs-devel@gnu.org; Sat, 16 Feb 2008 15:16:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQTSJ-0001xx-QS for emacs-devel@gnu.org; Sat, 16 Feb 2008 15:16:15 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JQTSF-000781-Uv; Sat, 16 Feb 2008 15:16:12 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CANbStkdMCpRc/2dsb2JhbACsT4EC X-IronPort-AV: E=Sophos;i="4.25,362,1199682000"; d="scan'208";a="14620710" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 16 Feb 2008 15:16:08 -0500 Original-Received: from pastel.home ([76.10.148.92]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id WWG67508; Sat, 16 Feb 2008 15:16:08 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id F0B437FCA; Sat, 16 Feb 2008 15:16:07 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Sat, 16 Feb 2008 19:12:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89269 Archived-At: >> So how about changing the loop condition to >> >> (while (and (not (file-directory-p file)) (file-exists-p file)) >> >> ? No, that would defeat the whole purpose of this loop which is to walk up the hierarchy until we find a real directory. E.g. walk up from /some/dir/some/not/yet/existing/subdir/file up to /some/dir. I'll commit a fix. Stefan