From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: hash-table-{to, from}-alist
Date: Wed, 03 Dec 2008 21:05:54 -0500 [thread overview]
Message-ID: <jwvfxl4vgz6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <867i6hrrh9.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 03 Dec 2008 13:25:22 -0600")
> I took your other suggestions, except I don't pass Qnil parameters to
> make-hash-table to keep things clean. I hope this version of the patch
> is acceptable.
Some nitpicks, see below.
BTW, have you tried to delegate to some Elisp code?
> + /*
> + Accept extended format for hashtables (extensible to
> + other types), e.g.
> + #s(hash-table size 2 test equal data (k1 v1 k2 v2))
> + */
We like to avoid putting comment markers on their own line. So we'd write
/* Accept extended format for hashtables (extensible to
other types), e.g.
#s(hash-table size 2 test equal data (k1 v1 k2 v2)) */
> + /* 2 * number of allowed keywords to make-hash-table */
We like to terminate our comments like sentences: with a sot followed by
2 spaces.
> + if (!NILP (params[param_count+1])) param_count+=2;
We like to put the body of the `if' on a separate line.
> + data = Fplist_get (tmp, Qdata); /* this is the hashtable data */
Comments should be capitalized: /* This is the hashtable data. */
> + Lisp_Object ht = Fmake_hash_table (param_count, params);
> + Lisp_Object key = Qnil;
We recently decided it was OK to use ANSI C syntax for function headers,
but I don't think ANSI C allows such variable declarations in the middle
of a block. So we should probably move the delcaration of those 2 vars
higher up, or open up a new block.
Other than that, it looks good.
Stefan
next prev parent reply other threads:[~2008-12-04 2:05 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 1:01 print hash table to disk and reread in hash table Xah
2008-08-28 5:21 ` Thierry Volpiatto
[not found] ` <mailman.17732.1219901096.18990.help-gnu-emacs@gnu.org>
2008-08-28 5:27 ` Xah
2008-08-28 6:17 ` Thierry Volpiatto
2008-08-28 14:03 ` Ted Zlatanov
2008-08-28 18:10 ` Eli Zaretskii
[not found] ` <mailman.17796.1219947087.18990.help-gnu-emacs@gnu.org>
2008-08-29 14:06 ` Ted Zlatanov
2008-08-29 14:52 ` Eli Zaretskii
[not found] ` <mailman.17897.1220021571.18990.help-gnu-emacs@gnu.org>
2008-08-29 18:10 ` Ted Zlatanov
2008-08-30 5:18 ` tomas
2008-08-30 9:17 ` Ted Zlatanov
2008-08-30 12:03 ` tomas
2008-11-17 17:15 ` Ted Zlatanov
2008-11-19 21:37 ` hash-table-{to, from}-alist (was: print hash table to disk and reread in hash table) Ted Zlatanov
2008-11-19 21:57 ` hash-table-{to, from}-alist Glenn Morris
2008-11-20 19:07 ` Ted Zlatanov
2008-11-21 22:02 ` Stefan Monnier
2008-11-21 22:22 ` Ted Zlatanov
2008-11-22 3:18 ` Stefan Monnier
2008-11-22 5:45 ` tomas
2008-11-22 12:27 ` Stephen J. Turnbull
2008-11-22 15:21 ` tomas
2008-11-22 17:38 ` Stephen J. Turnbull
2008-11-24 15:44 ` Richard M Stallman
2008-11-24 16:58 ` Stefan Monnier
2008-11-24 17:21 ` Ted Zlatanov
2008-11-25 1:50 ` Stephen J. Turnbull
2008-11-25 17:33 ` Ted Zlatanov
2008-11-25 23:50 ` Ted Zlatanov
2008-11-26 1:46 ` Stefan Monnier
2008-11-26 2:16 ` David De La Harpe Golden
2008-11-26 3:48 ` Stefan Monnier
2008-11-26 5:46 ` David De La Harpe Golden
2008-11-26 2:29 ` Stephen J. Turnbull
2008-11-26 3:34 ` David De La Harpe Golden
2008-11-26 16:06 ` Ted Zlatanov
2008-11-26 18:10 ` Stefan Monnier
2008-11-26 20:37 ` Ted Zlatanov
2008-11-26 21:16 ` Ted Zlatanov
2008-12-01 22:01 ` Ted Zlatanov
2008-12-02 0:13 ` Andreas Schwab
2008-12-02 14:27 ` Ted Zlatanov
2008-12-02 21:59 ` Stefan Monnier
2008-12-02 22:20 ` Andreas Schwab
2008-12-02 20:56 ` Ted Zlatanov
2008-12-02 21:27 ` Andreas Schwab
2008-12-02 21:58 ` Stefan Monnier
2008-12-03 19:25 ` Ted Zlatanov
2008-12-04 2:05 ` Stefan Monnier [this message]
2008-12-04 6:23 ` Stephen J. Turnbull
2008-12-04 6:34 ` Miles Bader
2008-12-04 9:08 ` Andreas Schwab
2008-12-04 13:18 ` Stefan Monnier
2008-12-04 15:02 ` Ted Zlatanov
2008-12-04 19:34 ` Stefan Monnier
2008-12-04 19:57 ` Ted Zlatanov
2009-07-30 18:24 ` Ted Zlatanov
2009-07-30 19:08 ` Chong Yidong
2009-07-30 19:22 ` Ted Zlatanov
2009-07-30 19:40 ` Chong Yidong
2009-07-30 21:04 ` Stefan Monnier
2009-07-31 1:30 ` Stefan Monnier
2009-07-31 17:49 ` Ted Zlatanov
2009-07-31 19:03 ` Stefan Monnier
2009-07-31 20:25 ` Ted Zlatanov
2009-08-01 2:22 ` Stephen J. Turnbull
2009-08-01 11:35 ` Chong Yidong
2009-08-03 14:53 ` Ted Zlatanov
2009-08-05 9:20 ` Ted Zlatanov
2009-08-05 13:48 ` Chong Yidong
2009-08-05 16:48 ` Ted Zlatanov
2009-08-06 16:30 ` Stefan Monnier
2009-08-06 16:47 ` Ted Zlatanov
2009-08-08 18:36 ` Chong Yidong
2009-08-06 10:13 ` Dan Nicolaescu
2009-08-06 16:58 ` Florian Beck
2009-08-03 21:23 ` Stefan Monnier
2009-07-31 18:10 ` Ted Zlatanov
2008-11-27 0:24 ` Stephen J. Turnbull
2008-12-01 21:53 ` Ted Zlatanov
2008-12-02 9:05 ` Stephen J. Turnbull
2008-12-02 14:21 ` Ted Zlatanov
2008-12-02 15:54 ` Stephen J. Turnbull
2008-12-02 16:10 ` Ted Zlatanov
2008-12-02 16:54 ` Stephen J. Turnbull
2008-12-02 22:19 ` Stefan Monnier
2008-12-02 23:27 ` Ted Zlatanov
2008-11-26 19:44 ` Davis Herring
2008-11-26 20:41 ` Ted Zlatanov
2008-11-25 2:57 ` Stefan Monnier
2008-11-25 7:02 ` Stephen J. Turnbull
2008-11-22 6:07 ` Miles Bader
2008-11-22 15:27 ` tomas
2008-11-22 18:57 ` Ted Zlatanov
2008-08-28 8:36 ` print hash table to disk and reread in hash table Niels Giesen
2008-10-10 20:38 ` harven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfxl4vgz6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.